-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow failing with "relax" and "autopilot" mods #25917
Conversation
Allows the Relax mod to fail, and remove NF/PF/SD mod exclusion ref: ppy#13229
I think historically the reason for keeping this was that it's for "relaxing play" or something like that. But to be honest, I would be okay with having it be allowed to fail... @peppy thoughts? |
Was only being used by `NoFail` now.
Sounds fine to me. |
418f106
to
14d2d0d
Compare
Uh well this is headed towards merge much faster than I'd expect it to? What are the implications of merging this on stable? Is stable relax also going to get changed too, or is this a "don't care about stable" sort of merge? |
Does this make RX/AP compatible with Accuracy Challenge as well? If not, I think it should. |
yes it will / does |
don't care too much. apparently replays are already broken (as in they don't work), so it's going to need future consideration.
yes |
Doing this on stable would be great as well, given it's unranked on stable not a lot of changes would be needed either. People seemingly have been asking for this for ages |
It is not going to happen on stable. |
Addresses #13229
I have changed the Relax mod to allow the player to fail, and as a result removing the NF/PF/SD mod exclusions with Relax. A significant portion of players that play on Relax-specific private servers use some sort of osu! stable patcher that does the same thing as this PR since, as an example, it's frustrating when trying to grind an SS with Relax. I don't see why Relax should essentially be bundled with NoFail as that should be enableable separately.
Additionally, while not covered in the discussion post linked above, Autopilot falls into the same category here and I think it should be addressed in the same way as Relax.
A significant portion of players that play primarily using relax mod have asked for the ability to compile relax with other mods, such as "perfect". This wasn't possible until now as relax blocked failing.
This change allows both "relax" and "autopilot" mods to fail, and as a result allows combining "no fail", "perfect" and "sudden death" with them.
If you're a relax player and want to keep the mod as relaxing as you remember it to, you can make a mod preset with RX+NF!