Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow failing with "relax" and "autopilot" mods #25917

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

rushiiMachine
Copy link
Contributor

@rushiiMachine rushiiMachine commented Dec 19, 2023

Addresses #13229

I have changed the Relax mod to allow the player to fail, and as a result removing the NF/PF/SD mod exclusions with Relax. A significant portion of players that play on Relax-specific private servers use some sort of osu! stable patcher that does the same thing as this PR since, as an example, it's frustrating when trying to grind an SS with Relax. I don't see why Relax should essentially be bundled with NoFail as that should be enableable separately.

Additionally, while not covered in the discussion post linked above, Autopilot falls into the same category here and I think it should be addressed in the same way as Relax.


A significant portion of players that play primarily using relax mod have asked for the ability to compile relax with other mods, such as "perfect". This wasn't possible until now as relax blocked failing.

This change allows both "relax" and "autopilot" mods to fail, and as a result allows combining "no fail", "perfect" and "sudden death" with them.

If you're a relax player and want to keep the mod as relaxing as you remember it to, you can make a mod preset with RX+NF!

Allows the Relax mod to fail, and remove NF/PF/SD mod exclusion

ref: ppy#13229
@smoogipoo
Copy link
Contributor

I think historically the reason for keeping this was that it's for "relaxing play" or something like that. But to be honest, I would be okay with having it be allowed to fail... @peppy thoughts?

@peppy peppy self-requested a review December 20, 2023 05:39
Was only being used by `NoFail` now.
@peppy
Copy link
Member

peppy commented Dec 20, 2023

Sounds fine to me.

@peppy peppy changed the title Allow Relax to fail and remove failable mod exclusions Allow failing with "relax" and "autopilot" mods Dec 20, 2023
@peppy peppy enabled auto-merge December 20, 2023 06:02
@bdach
Copy link
Collaborator

bdach commented Dec 20, 2023

Uh well this is headed towards merge much faster than I'd expect it to?

What are the implications of merging this on stable? Is stable relax also going to get changed too, or is this a "don't care about stable" sort of merge?

@Ratchet0203
Copy link

Does this make RX/AP compatible with Accuracy Challenge as well? If not, I think it should.

@bdach
Copy link
Collaborator

bdach commented Dec 20, 2023

Does this make RX/AP compatible with Accuracy Challenge as well? If not, I think it should.

yes it will / does

@peppy
Copy link
Member

peppy commented Dec 20, 2023

Uh well this is headed towards merge much faster than I'd expect it to?

What are the implications of merging this on stable? Is stable relax also going to get changed too, or is this a "don't care about stable" sort of merge?

don't care too much. apparently replays are already broken (as in they don't work), so it's going to need future consideration.

Does this make RX/AP compatible with Accuracy Challenge as well? If not, I think it should.

yes

@peppy peppy disabled auto-merge December 20, 2023 06:48
@peppy peppy merged commit 98efff0 into ppy:master Dec 20, 2023
@rushiiMachine rushiiMachine deleted the remove-relax-mod-exclusions branch December 20, 2023 07:28
@rushiiMachine
Copy link
Contributor Author

rushiiMachine commented Dec 20, 2023

What are the implications of merging this on stable? Is stable relax also going to get changed too, or is this a "don't care about stable" sort of merge?

Doing this on stable would be great as well, given it's unranked on stable not a lot of changes would be needed either. People seemingly have been asking for this for ages

@smoogipoo
Copy link
Contributor

It is not going to happen on stable.

@ppy ppy locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants