Adjust classic slider mechanics to better mimic osu!stable #25732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Dec 12, 2023
Comment on lines
+94
to
+98
| /// <summary> | ||
| /// Whether the given <see cref="HitResult"/> affects combo in coordination with this <see cref="Judgement"/>. | ||
| /// </summary> | ||
| /// <param name="result">The hit result.</param> | ||
| public virtual bool AffectsCombo(HitResult result) => result.AffectsCombo(); |
There was a problem hiding this comment.
Uh... when I proposed this flag months ago you brought up that this has implications on other components that rely on MaximumStatistics to compute max combo. So... how are they going to be addressed?
Because as far as I can see
is not changed in this pull and becomes straight up incorrect with this change?
There was a problem hiding this comment.
I... totally forgot about that...
|
As per above comment, this needs more thinking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes / closes #25594
Resolves #11769
We're not going to be changing the lazer mechanics for the time being. Even so, it's worth making the classic mod more faithfully reproduce osu!stable's mechanics.
Great / Ok / Meh / MissLargeTickHit / LargeTickMissLargeTickHit / LargeTickMissLargeTickHit / LargeTickMissLargeTickHit / LargeTickMissLargeTickHit / LargeTickMissLargeTickHit / IgnoreMissLargeTickHit / IgnoreMissIgnoreHit / IgnoreMissGreat / Ok / Meh / Miss(no combo gain)Note that this does mean the number of slider ticks between NM and CL are different, but I think this is fine. Historically, ticks haven't been displayed on the results screen, and ticks themselves are not used for any calculations.