Reduce inflate effect when scaling an element in Skin Editor #25069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not really a solution I'm happy with... I believe this require conversation.
|
This is not the correct solution, as you've said yourself. The correct solution likely involves performing the inflation operation in screen space rather than in the local space of the skin component as the current code does.
Re-read what was stated.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25049.
I am not happy with this proposal. The “problem” remains, but I am unsure which path to go with, considering peppy said that it was an intended effect. (See linked issue)
I was thinking of limiting the inflation after it reaches a maximum inflation (Say 1.2 from original size), and limit the container to that maximum.
Please, let me know what you would see fit best.