Skip to content

Move mod overlay difficulty multiplier display to bottom of screen #24799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 14, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Sep 13, 2023

In order to aid the user in knowing how their mod customisation is affecting the score multiplier, this needs to be displayed at the bottom of the screen.

This comes with a few layout change considerations. Applied in this PR:

  • The flow of information now becomes vertical when it can't fit on the bottom line.

In upcoming PRs:

  • The difficulty multiplier display's visuals will be updated to match the beatmap attribute display. This is a large-ish refactor, so will be a separate PR.
  • The mod search textbox feels like it could be merged with the header, rather than taking up a full line. Needs further investigation. Dropping this for now. The design in figma doesn't match what we have at all, and attempting to get the search control to fit in the header is fruitless.

Addresses part of the usability concern in #24674.

osu.2023-09-13.at.09.31.16.mp4

(video was taken with partial visual changes applied which are not in this PR)

@bdach bdach enabled auto-merge September 14, 2023 09:33
@bdach bdach disabled auto-merge September 14, 2023 10:11
@bdach bdach merged commit 5bda9a3 into ppy:master Sep 14, 2023
@peppy peppy deleted the move-mod-select-diff-multiplier branch September 15, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants