-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Implement beatmap options popover #24712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I saw in the GIF that it says "rewind" when you hold shift (for when you're rewinding random). I think this should also change the icon to better signify that. (it isn't in the Figma, but it would be a nice addition) |
/// <summary> | ||
/// "General" | ||
/// </summary> | ||
public static LocalisableString General => new TranslatableString(getKey(@"general"), @"General"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about having "general" in so many places for translation.
public static LocalisableString GeneralHeader => new TranslatableString(getKey(@"general_header"), @"General"); |
is at least one other example.
Maybe these should be in the general localisations as a single string?
BeatmapOptionsOverlay
is missing new design #24273Some differences to the proposed design:
I had to take a different approach to add the buttons to the popover content since popovers are reconstructed every time.
The old
BeatmapOptionsOverlay
hadSongSelect
adding the buttons, and if you wanted to make an isolated test scene, you would have to copy the adding logic. It is now local by using DI.Here's a WIP branch for the footer integrated into the game: master...Joehuu:osu:footer-redesign