Fix accuracy break info decimal separator being incorrect in certain languages #24406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Joehuu
commented
Jul 29, 2023
Joehuu
commented
- Addresses Wrong decimal separator during break #24400
bdach
reviewed
Jul 29, 2023
bdach
reviewed
Jul 29, 2023
| return; | ||
|
|
||
| valueText.Text = newText; | ||
| Current.BindValueChanged(text => valueText.Text = Format(text.NewValue), true); |
There was a problem hiding this comment.
Went too far here. The BindValueChanged(..., true) spec actually alters behaviour because it makes the initial Text spec of "-" on valueText useless (it will always be replaced by whatever Format() spits out at the point of LoadComplete()).
bdach
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.