Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing gameplay skin does not update when paused #7285

Open
Gabixel opened this issue Dec 19, 2019 · 1 comment
Open

Changing gameplay skin does not update when paused #7285

Gabixel opened this issue Dec 19, 2019 · 1 comment
Labels
area:skinning priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@Gabixel
Copy link
Contributor

Gabixel commented Dec 19, 2019 •
edited
Loading

Describe the bug: If you change the skin while in the pause overlay, it will update only after resuming the game.

Screenshots or videos showing encountered issue:

Skin.updating.issue.mp4

osu!lazer version: 2019.1219.0
@peppy
Copy link
Member

peppy commented Dec 20, 2019

This is due to gameplay being paused at a drawable level. I can agree that having it immediately update is better UX, but not sure we want to change this without careful consideration.

@peppy peppy removed the bug label Dec 20, 2019
@peppy peppy removed the overlays label Feb 12, 2020
@monochrome22 monochrome22 mentioned this issue May 16, 2023
Closed
@monochrome22 monochrome22 mentioned this issue Jul 17, 2023
Closed
@peppy peppy added the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Jul 17, 2023
shiumano added a commit to shiumano/osu that referenced this issue Jun 13, 2024
@shiumano
Eliminate meaningless processes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
e9bb454 
It wasn't even a spell. Eventually ppy#7285 dragged its feet.
@frenzibyte frenzibyte changed the title Gameplay skin doesn't update in pause overlay Changing gameplay skin does not update when paused Jan 17, 2025
@frenzibyte frenzibyte mentioned this issue Jan 17, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:skinning priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peppy @bdach @Gabixel