Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beatmap set overlay header elements are not aligned correctly #32348

Closed
bdach opened this issue Mar 12, 2025 · 0 comments · Fixed by #32349
Closed

Beatmap set overlay header elements are not aligned correctly #32348

bdach opened this issue Mar 12, 2025 · 0 comments · Fixed by #32349
Assignees
@bdach
Labels
area:overlay-beatmap osu!framework issue Can't resolve this without changes to osu!framework. type:cosmetic

Comments

@bdach
Copy link
Collaborator

bdach commented Mar 12, 2025

Image

See "external link" button specifically - it's supposed to be aligned with the text baseline.

Broke in ppy/osu-framework#6545. Fixing.
@bdach bdach added area:overlay-beatmap osu!framework issue Can't resolve this without changes to osu!framework. type:cosmetic labels Mar 12, 2025
@bdach bdach self-assigned this Mar 12, 2025
bdach added a commit to bdach/osu-framework that referenced this issue Mar 12, 2025
@bdach
Only consider flowing children when performing layout of text flow
9df0e91 
Fixes one part of ppy/osu#32348.

The reason this is required is due to the game-side abuse done by
`DrawableLinkCompiler` & co. See the following:

	https://github.com/ppy/osu/blob/4633f635a4137d6af902187e12d6fc360bc3a50d/osu.Game/Graphics/Containers/LinkFlowContainer.cs#L141-L144

`FillFlowContainer` performs layout computations on `FlowingChildren`
specifically:

	https://github.com/ppy/osu-framework/blob/1ccf0376c4306cb4077d0e3230f60efb92ea7803/osu.Framework/Graphics/Containers/FillFlowContainer.cs#L113

Because of this, if using `Flow.Children` in `TextFlowContainer`, the
`DrawableLinkCompiler` - which was skipped by the inner fill flow - is
now being considered for layout at the text flow level. Text flow sees
that the X position of the compiler is 0 (because it wasn't touched by
the inner fill flow), and thus thinks it must be a line break, which
it's not.

So we use `FlowingChildren` to restore parity.
@bdach bdach mentioned this issue Mar 12, 2025
Merged
@bdach bdach mentioned this issue Mar 12, 2025
Merged
2 tasks
@peppy peppy closed this as completed in 17f964d Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:overlay-beatmap osu!framework issue Can't resolve this without changes to osu!framework. type:cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix OsuTextFlowContainer.AddArbitraryDrawable() not aligning the drawable correctly bdach/osu
1 participant
@bdach