Offline players stay on the online tab at the dashboard

[Ladwick]

Type

Game behaviour

Bug description

As expected from #31524, online changes should be happening in real time, and some are, but some offline players manage to get on the online tab, initially I thought they were left there after they were online and then disconnected but that doesn't seems to be the case, since there were offline players as soon as I started lazer, as seen on the pic (compare the last seen to the running time).

On a side note, people connecting to the game that is not on the online tab already will appear to be online on the offline tab...

Screenshots or videos

Version

2025.220.0

Logs

compressed-logs.zip

[bdach]

Two immediate things:

• This display's filtering is based on APIUser.IsOnline which comes from API, is not bindable, and never gets updated:

  osu/osu.Game/Overlays/Dashboard/Friends/FriendDisplay.cs

  Lines 220 to 224 in 1e3d5d7

  	case OnlineStatus.Offline:
  	return users.Where(u => !u.IsOnline).ToList();
  	case OnlineStatus.Online:
  	return users.Where(u => u.IsOnline).ToList();

  Moreover, the displayed status is fetched by the panel drawables manually in a way that makes it impossible for the entire list to even access it:

  osu/osu.Game/Users/ExtendedUserPanel.cs

  Lines 91 to 95 in 1e3d5d7

  	private void updatePresence()
  	{
  	UserPresence? presence = metadata?.GetPresence(User.OnlineID);
  	UserStatus status = presence?.Status ?? UserStatus.Offline;
  	UserActivity? activity = presence?.Activity;

• "Being online" in the API sense of the word is not "being online" in the spectator server metadata hub sense. You could be online on stable, or on the website. The API property is based on updates to user_lastvisit in DB and an implicit window of "onlineness" is assumed. So even if the first issue is fixed then we'll get mismatches between what the website shows in this view and what the client shows.

This is not a quick fix and I dunno what would be the agreeable way to proceed here. cc @smoogipoo @peppy

[smoogipoo]

Was keenly aware the IsOnline stuff is bad here and here, and will need a lot of massaging.

As for the friends overlay, perhaps we can bind to MetadataClient.FriendPresences instead. The rest, I believe the discussions ended at possibly having the ability to watch individual users in addition to friends/global via the metadata hub, if necessary.

[peppy]

We should definitely push in the direction of making online state based on spectator-server, and ignore the osu-web property. I think that property is only useful for things like the web profile display where we want a general idea of the user's current online state (bancho updates it on a schedule when a user is online, for instance).

[GAMIS65]

Because of this, you have to restart your game if you want to spectate or invite a player who comes online after you.

[peppy]

Bumping to p0 due to #31966 (comment). Sounds like spectator is completely broken due to this.

[smoogipoo]

I'll tentatively assign to myself and see if I can get something quick out.