Skip to content

Personal best should be shown on gameplay leaderboards #26716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peppy opened this issue Jan 26, 2024 · 0 comments · Fixed by #32494
Closed

Personal best should be shown on gameplay leaderboards #26716

peppy opened this issue Jan 26, 2024 · 0 comments · Fixed by #32494
Assignees
@bdach
Labels
area:gameplay

Comments

@peppy
Copy link
Member

peppy commented Jan 26, 2024

This is done in stable and feels very missing.

I'll also use this as an opportunity to improve/remove the flow of scores from song select to gameplay.
@peppy peppy self-assigned this Jan 26, 2024
@peppy peppy moved this from Needs discussion to Needs implementation in osu! client development focus Jan 26, 2024
@bdach bdach assigned bdach and unassigned peppy Jan 30, 2025
bdach added a commit to bdach/osu that referenced this issue Apr 8, 2025
@bdach
Actually use leaderboard manager in players
16b817b 
This was supposed to be the case all along, but I guess in all of the
rewrite attempts I forgot?

With this, ppy#29861 is actually fixed
again - and additionally, so is ppy#26716,
and ppy#26331.
@bdach bdach mentioned this issue Apr 8, 2025
Merged
bdach added a commit to bdach/osu that referenced this issue Apr 10, 2025
@bdach
Actually use leaderboard manager in players
42ff312 
This was supposed to be the case all along, but I guess in all of the
rewrite attempts I forgot?

With this, ppy#29861 is actually fixed
again - and additionally, so is ppy#26716.
@github-project-automation github-project-automation bot moved this from Needs implementation to Done in osu! client development focus Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:gameplay
Projects
osu! client development focus
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract leaderboard fetch logic from song select beatmap leaderboard drawable bdach/osu
2 participants
@peppy @bdach