Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when starting beatmap by clicking osu! logo and immediately canceling the start #26415

Closed
wooster0 opened this issue Jan 6, 2024 · 1 comment · Fixed by #26437
Closed

Comments

@wooster0
Copy link
Contributor

wooster0 commented Jan 6, 2024

Type

Crash to desktop

Bug description

Select a beatmap in solo song select and start the beatmap by clicking the osu! logo in the bottom right and then as soon as the beatmap start has been initiated, cancel the start as quickly as possible by pressing the escape key.

I cannot reproduce this by using the enter key instead to start the beatmap. I can't reproduce it by clicking on the beatmap difficulty instead of the osu! logo to start the beatmap, either. Only clicking the osu! logo with the mouse to start seems to trigger this crash.

[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Input.MouseButtonEventManager.handleClick(InputState state, List`1 targets)
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Input.MouseButtonEventManager.HandleButtonUp(InputState state, List`1 targets)
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Input.ButtonEventManager`1.handleButtonUp(InputState state)
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Input.InputManager.HandleMouseButtonStateChange(ButtonStateChangeEvent`1 e)
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Input.UserInputManager.HandleInputStateChange(InputStateChangeEvent inputStateChange)
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Input.StateChanges.ButtonInput`1.Apply(InputState state, IInputStateChangeHandler handler)
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Input.InputManager.Update()
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Input.PassThroughInputManager.Update()
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Graphics.Drawable.UpdateSubTree()
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Platform.GameHost.UpdateFrame()
[runtime] 2022-01-06 15:16:25 [error]: at osu.Framework.Threading.GameThread.processFrame()
[runtime] 2022-01-06 15:16:25 [verbose]: Unhandled exception has been denied .
Unhandled exception. osu.Framework.Screens.ScreenStack+ScreenNotCurrentException: Cannot perform Push on a non-current screen.
   at osu.Framework.Screens.ScreenStack.Push(IScreen source, IScreen newScreen)
   at osu.Framework.Screens.ScreenExtensions.Push(IScreen screen, IScreen newScreen)
   at osu.Game.Screens.Select.PlaySongSelect.OnStart() in /home/wooster/osu/osu.Game/Screens/Select/PlaySongSelect.cs:line 119
   at osu.Game.Screens.Select.SongSelect.FinaliseSelection(BeatmapInfo beatmapInfo, RulesetInfo ruleset, Action customStartAction) in /home/wooster/osu/osu.Game/Screens/Select/SongSelect.cs:line 482
   at osu.Game.Screens.Select.SongSelect.<LogoArriving>b__102_0() in /home/wooster/osu/osu.Game/Screens/Select/SongSelect.cs:line 663
   at osu.Game.Screens.Menu.OsuLogo.OnClick(ClickEvent e) in /home/wooster/osu/osu.Game/Screens/Menu/OsuLogo.cs:line 393
   at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`-1 source, Func`2 predicate, Boolean& found)
   at osu.Framework.Input.ButtonEventManager`-1.PropagateButtonEvent(IEnumerable`1 drawables, UIEvent e)
   at osu.Framework.Input.MouseButtonEventManager.handleClick(InputState state, List`-1 targets)
   at osu.Framework.Input.MouseButtonEventManager.HandleButtonUp(InputState state, List`-1 targets)
   at osu.Framework.Input.ButtonEventManager`-1.handleButtonUp(InputState state)
   at osu.Framework.Input.InputManager.HandleMouseButtonStateChange(ButtonStateChangeEvent`-1 e)
   at osu.Framework.Input.UserInputManager.HandleInputStateChange(InputStateChangeEvent inputStateChange)
   at osu.Framework.Input.StateChanges.ButtonInput`-1.Apply(InputState state, IInputStateChangeHandler handler)
   at osu.Framework.Input.InputManager.Update()
   at osu.Framework.Input.PassThroughInputManager.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
--- End of stack trace from previous location ---
   at osu.Framework.Platform.GameHost.<>c__DisplayClass139_0.<abortExecutionFromException>b__0()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.SDL0Window.RunMainLoop()
   at osu.Framework.Platform.SDL0Window.Run()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at osu.Desktop.Program.Main(String[] args) in /home/wooster/osu/osu.Desktop/Program.cs:line 124

It seems to be possible to fix this by adding a naive "is not null" check but because this only happens by clicking the osu! logo I think there might be more to this.

Screenshots or videos

No response

Version

commit fbc40ff

Logs

See above

@ppy-sentryintegration
Copy link

Sentry issue: OSU-J1D

bdach added a commit to bdach/osu that referenced this issue Jan 8, 2024
…iting

Closes ppy#26415.

The crash report with incomplete log was backwards, the exit comes
first. Sentry events and the reproducing test in
8a87301 confirm this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants