Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.ArgumentException: X must be finite, but is -∞. #26213

Closed
ppy-sentryintegration bot opened this issue Dec 29, 2023 · 0 comments · Fixed by #26219
Closed

System.ArgumentException: X must be finite, but is -∞. #26213

ppy-sentryintegration bot opened this issue Dec 29, 2023 · 0 comments · Fixed by #26219
Assignees
@bdach
Labels
area:editor priority:0 Showstopper. Critical to the next release. type:reliability

Comments

@ppy-sentryintegration
Copy link

Sentry Issue: OSU-W42

System.ArgumentException: X must be finite, but is -∞.
  ?, in void Drawable.set_X(float value)
  ?, in void Timeline.load(IBindable<WorkingBeatmap> beatmap, OsuColour colours, OsuConfigManager config)+(ValueChangedEvent<Track> _) => { }
  ?, in void Bindable<T>.TriggerValueChange(T previousValue, Bindable<T> source, bool propagateToBindings, bool bypassChecks) x 2
  ?, in void Bindable<T>.set_Value(T value)
  ?, in void EditorClock.ChangeSource(IClock source)
...
(21 additional frame(s) were not displayed)

An unhandled error has occurred.
@bdach bdach added priority:0 Showstopper. Critical to the next release. area:editor type:reliability labels Dec 29, 2023
@bdach bdach self-assigned this Dec 29, 2023
bdach added a commit to bdach/osu that referenced this issue Dec 29, 2023
@bdach
Fix crash after changing audio track in editor
cd1f6b4 
Closes ppy#26213.

Reproduction scenario: switch audio track in editor after timeline
loads.

Happens because `beatmap.Value.Track.Length` is 0 immediately after a
track switch, until BASS computes the actual track length on the audio
thread.

Yes this is a hack. No I have no better immediate ideas how to address
this otherwise.
@bdach bdach mentioned this issue Dec 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdach bdach

Labels
area:editor priority:0 Showstopper. Critical to the next release. type:reliability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash after changing audio track in editor bdach/osu
1 participant
@bdach