Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fruits in osu!catch have inconsistent layering #25827

Closed
Ratchet0203 opened this issue Dec 18, 2023 · 3 comments · Fixed by #26336
Closed

Fruits in osu!catch have inconsistent layering #25827

Ratchet0203 opened this issue Dec 18, 2023 · 3 comments · Fixed by #26336
Labels
area:gameplay priority:1 Very important. Feels bad without fix. Affects the majority of users. ruleset/osu!catch

Comments

@Ratchet0203
Copy link

Type

Cosmetic

Bug description

Often times, fruits will be in front of the one before them instead of behind. This is especially noticeable on low CS/AR when fruits overlap more frequently, and can be very distracting to read. I encounter this on any map in the game, convert or not. This behavior is seemingly random, but there may be a pattern I'm missing.

Screenshots or videos

Stable
image
Lazer
image

Version

2023.1218.0-lazer

Logs

1702886474.input.log
1702886474.network.log
1702886474.performance.log
1702886474.runtime.log
1702886474.updater.log
1702888868.input.log
1702888868.network.log
1702888868.performance.log
1702888868.runtime.log
1702888868.updater.log
1702889710.input.log
1702889710.network.log
1702889710.performance.log
1702889710.runtime.log
1702889710.updater.log
1702877164.database.log
1702877164.input.log
1702877164.network.log
1702877164.performance.log
1702877164.runtime.log
1702877164.updater.log

@bdach
Copy link
Collaborator

bdach commented Dec 18, 2023

Just for sanity purposes, can you link the specific map on the screenshot? Timestamp would also help.

@Ratchet0203
Copy link
Author

Those screenshots were taken 31 seconds into https://osu.ppy.sh/beatmapsets/1948778#fruits/4033827. It's a convert so you won't be able to look in the editor, but I can find an example on a man made catch map if you'd like.

@bdach
Copy link
Collaborator

bdach commented Dec 18, 2023

That's good enough, thanks.

@bdach bdach added the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Dec 20, 2023
bdach added a commit to bdach/osu that referenced this issue Jan 2, 2024
Closes ppy#25827.

The logic cannot be easily abstracted out (because
`CompareReverseChildID()` is protected and non-static on
`CompositeDrawable`), so a local copy was applied instead.

No testing as any testing would have been purely visual anyways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gameplay priority:1 Very important. Feels bad without fix. Affects the majority of users. ruleset/osu!catch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants