Add the ability to solo a test in visual testing using [Solo] attribute
#6137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Susko3
reviewed
Jan 16, 2024
osu.Framework/Testing/TestBrowser.cs
Outdated
Comment on lines
405
to
407
| var solo = methods.FirstOrDefault(m => m.GetCustomAttribute(typeof(SoloAttribute), false) != null); | ||
| if (solo != null) | ||
| methods = new[] { solo }; |
There was a problem hiding this comment.
Why not allow multiple solo methods? Change the logic to a .Select() and overwrite methods only if the resulting array is non-empty.
Would be useful for testing two or more specific methods.
There was a problem hiding this comment.
Sure, sounds fine I think.
|
Hope this one can get in as a quick change. I was just trying to use it and realised it's still not merged 🥲 . |
smoogipoo
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been wanting this for years. Discussed implementation details recently with smoogi and agreed that getting something very simple implemented would be beneficial to test development efficiency.
Basically, rather than commenting out 100 tests in a method where you want to test one specific test repeatedly (commonly using hot reload), you can now add
[Solo]to the test in question and the runner will ignore the rest.This has no effect when tests are run from nunit, as you may expect.