Clean predefined results

[annetill]

Signed-off-by: Anne Tilloy anne.tilloy@rte-france.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

• The Breaking Change or Deprecated label has been added
• The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

[flo-dup]

Great cleaning!

[geofjamg]

@annetill @flo-dup
I tried performance comparison with main branch with such a code:

        Network network = Network.read("<path>");

        List<Contingency> contingencies = network.getLineStream()
                .filter(line -> line.getTerminal1().getVoltageLevel().getSubstation().map(Substation::getNullableCountry).orElse(null) == Country.FR
                        && line.getTerminal2().getVoltageLevel().getSubstation().map(Substation::getNullableCountry).orElse(null) == Country.FR)
                .limit(500)
                .map(line -> Contingency.line(line.getId()))
                .collect(Collectors.toList());

        List<Generator> generators = network.getGeneratorStream()
                .filter(g -> g.getTerminal().getVoltageLevel().getSubstation().map(Substation::getNullableCountry).orElse(null) == Country.FR)
                .limit(1000)
                .collect(Collectors.toList());

        List<Line> lines = network.getLineStream()
                .filter(line -> line.getTerminal1().getVoltageLevel().getSubstation().map(Substation::getNullableCountry).orElse(null) == Country.FR
                        && line.getTerminal2().getVoltageLevel().getSubstation().map(Substation::getNullableCountry).orElse(null) == Country.FR)
                .limit(1000)
                .collect(Collectors.toList());

        SensitivityFactorReader reader = new SensitivityFactorReader() {
            @Override
            public void read(Handler handler) {
                for (Line l : lines) {
                    for (Generator g : generators) {
                        handler.onFactor(SensitivityFunctionType.BRANCH_ACTIVE_POWER, l.getId(),
                                SensitivityVariableType.INJECTION_ACTIVE_POWER, g.getId(), false,
                                ContingencyContext.all());
                    }
                }
            }
        };

        SensitivityResultWriter writer = new SensitivityResultWriter() {
            @Override
            public void writeSensitivityValue(int i, int i1, double v, double v1) {

            }

            @Override
            public void writeContingencyStatus(int i, SensitivityAnalysisResult.Status status) {

            }
        };

        var parameters = new SensitivityAnalysisParameters();
        parameters.getLoadFlowParameters().setDc(true);

        Stopwatch stopwatch = Stopwatch.createStarted();

        SensitivityAnalysis.find("OpenLoadFlow")
                .run(network, VariantManagerConstants.INITIAL_VARIANT_ID, reader, writer, contingencies, List.of(),
                        parameters, LocalComputationManager.getDefault(), Reporter.NO_OP);

        System.out.println("Done in " + stopwatch.elapsed(TimeUnit.MILLISECONDS));

And surprisingly, this branch is much faster: 133 s vs 198 for main branch.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

95.0% Coverage
0.0% Duplication