Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NAD] List of displayed voltage levels as an output #551

Merged
merged 2 commits into from
Sep 26, 2023
Merged

[NAD] List of displayed voltage levels as an output #551

merged 2 commits into from
Sep 26, 2023

Conversation

tadam50
Copy link
Contributor

@tadam50 tadam50 commented Sep 26, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
'Fixes #547'

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@tadam50
Add method to get visible voltageLevels
dde15df 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 added the NAD label Sep 26, 2023
@tadam50 tadam50 requested a review from So-Fras September 26, 2023 10:19
@tadam50 tadam50 self-assigned this Sep 26, 2023
@tadam50 tadam50 linked an issue Sep 26, 2023 that may be closed by this pull request
[NAD] List of displayed voltage levels as an output #547
Closed
@tadam50
public static List<String> getDisplayedVoltageLevels(Network network,…
77e2049 
… List<String> voltageLevelIds, int depth)public static List<String> getDisplayedVoltageLevels(Network network, List<String> voltageLevelIds, int depth)

Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 force-pushed the 547-nad-list-of-displayed-voltage-levels-as-an-output branch from b1b3bb7 to 77e2049 Compare September 26, 2023 14:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@So-Fras So-Fras marked this pull request as ready for review September 26, 2023 19:58
@So-Fras
Copy link
Member

So-Fras commented Sep 26, 2023

Thanks for the quick work, let's make the python connection now!

@So-Fras So-Fras merged commit fbde9ea into main Sep 26, 2023
@So-Fras So-Fras deleted the 547-nad-list-of-displayed-voltage-levels-as-an-output branch September 26, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@So-Fras So-Fras So-Fras approved these changes

Assignees

@tadam50 tadam50

Labels
NAD
Projects
V4.0.0
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NAD] List of displayed voltage levels as an output
2 participants
@tadam50 @So-Fras