Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

536 viewbox incorrectly specified in some cases depending on the direction of a line between two voltage levels #540

Merged
merged 3 commits into from
Jul 31, 2023
Merged

536 viewbox incorrectly specified in some cases depending on the direction of a line between two voltage levels #540

merged 3 commits into from
Jul 31, 2023

Conversation

tadam50
Copy link
Contributor

@tadam50 tadam50 commented Jul 27, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
'Fixes #536'

tadam50 added 2 commits July 27, 2023 16:12
@tadam50
Add TestViewBox class: loading xiidm files & generate svg files
8a85d02 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Fix substation height computation
4ff46a2 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 requested a review from So-Fras July 27, 2023 14:14
@tadam50 tadam50 self-assigned this Jul 27, 2023
@tadam50 tadam50 added bug Something isn't working SLD labels Jul 27, 2023
@So-Fras
Merge branch 'main' into 536-viewbox-incorrectly-specified-in-some-ca…
7bba7be 
…ses-depending-on-the-direction-of-a-line-between-two-voltage-levels
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

So-Fras
So-Fras approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix and the associated tests!

@So-Fras So-Fras merged commit 34873c7 into main Jul 31, 2023
@So-Fras So-Fras deleted the 536-viewbox-incorrectly-specified-in-some-cases-depending-on-the-direction-of-a-line-between-two-voltage-levels branch July 31, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@So-Fras So-Fras So-Fras approved these changes

Assignees

@tadam50 tadam50

Labels
bug Something isn't working SLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Viewbox incorrectly specified in some cases depending on the direction of a line between two voltage levels
2 participants
@tadam50 @So-Fras