-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using horizontal & vertical layouts for ZoneGraph #518
Conversation
This is great, thanks! @tadam50, just have 1 question. I see there is a horizontal example and vertical example. But can vertical and horizontal layouts be combined in 1 svg ? For example we have 12 substations, then ideally we want to have 3 rows with each 4 substations... |
@flieks Indeed, this would be a lot better! But this would be in another PR, this PR introduces a very basic version to start simple. I'll write an issue for that feature, it would be nice if you could add some details about what you had in mind |
1a28286
to
0248753
Compare
@flo-dup @tadam50 Thanks for starting this PR, sorry for late reply I am trying to click on this one in the docs Because we need the vertical layout as you can see, our main substation busbars are vertical lines and then the connections that go to other substations are horizontal lines. It would be awesome if we could achieve something like this. Would this be possible with this PR or maybe another one ? Maybe we can help if you point us in the right direction of what should be changed/coded to get this working ? i puted this info condensed in the other PR 520 also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your nice work!
I didn't have time to finish my review, to be continued :)
...ram/single-line-diagram-core/src/main/java/com/powsybl/sld/builders/NetworkGraphBuilder.java
Outdated
Show resolved
Hide resolved
...ram/single-line-diagram-core/src/main/java/com/powsybl/sld/builders/NetworkGraphBuilder.java
Outdated
Show resolved
Hide resolved
...ram/single-line-diagram-core/src/main/java/com/powsybl/sld/builders/NetworkGraphBuilder.java
Outdated
Show resolved
Hide resolved
...ram/single-line-diagram-core/src/main/java/com/powsybl/sld/builders/NetworkGraphBuilder.java
Outdated
Show resolved
Hide resolved
...ram/single-line-diagram-core/src/main/java/com/powsybl/sld/builders/NetworkGraphBuilder.java
Outdated
Show resolved
Hide resolved
...ram/single-line-diagram-core/src/main/java/com/powsybl/sld/builders/NetworkGraphBuilder.java
Outdated
Show resolved
Hide resolved
...diagram/single-line-diagram-core/src/test/java/com/powsybl/sld/iidm/TestCase13ZoneGraph.java
Outdated
Show resolved
Hide resolved
578d71a
to
1b60432
Compare
9df67bc
to
5b54803
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the huge amount of work you have put in this PR.
I made a minor comment, I would like to discuss it further with you because I do not get why there is a difference between substation and zone regarding layout naming (and furthermore I may be to blame here!).
...diagram/single-line-diagram-core/src/test/java/com/powsybl/sld/iidm/TestCase13ZoneGraph.java
Show resolved
Hide resolved
0ae9423
to
95c1fc2
Compare
Kudos, SonarCloud Quality Gate passed! |
ce57421
to
ee267c8
Compare
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
…interfaces Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
…oSnakeLines Signed-off-by: Thomas ADAM <tadam@silicom.fr>
d67e664
to
8508c30
Compare
Kudos, SonarCloud Quality Gate passed! |
Some configurations (VH and HV) do not offer a clear and completly satisfying display. But this PR is a first attempt to display multi-substation graphs. It will be followed by another PR to represent multi-substation graphs according to a matrix design. |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
No layouts for Zone graph are available
What is the new behavior (if this is a feature change)?
Provide horizontal and vertical layouts for Zone graph
Does this PR introduce a breaking change or deprecate an API?
Other information: