Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge name not displayed by default #504

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Conversation

So-Fras
Copy link
Member

@So-Fras So-Fras commented Mar 10, 2023

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR changes the default behaviour for line name display.

What is the current behavior? (You can also link to an open issue here)
By default, line names are displayed.

What is the new behavior (if this is a feature change)?
By default, line names are not displayed.

So-Fras added 2 commits March 10, 2023 14:46
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
@So-Fras So-Fras requested a review from flo-dup March 10, 2023 13:52
@So-Fras So-Fras added the NAD label Mar 10, 2023
@So-Fras So-Fras self-assigned this Mar 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@flo-dup flo-dup merged commit 8b3b8c9 into main Mar 20, 2023
@flo-dup flo-dup deleted the edge_name_not_displayed_default branch March 20, 2023 15:21
BenoitJeanson pushed a commit that referenced this pull request May 2, 2023
* name on line not displayed by default + refactoring
* update test references

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Signed-off-by: BenoitJeanson <benoit.jeanson@rte-france.com>
BenoitJeanson pushed a commit that referenced this pull request May 4, 2023
* name on line not displayed by default + refactoring
* update test references

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
BenoitJeanson pushed a commit that referenced this pull request May 4, 2023
* name on line not displayed by default + refactoring
* update test references

Signed-off-by: Sophie Frasnedo <sophie.frasnedo@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants