Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cgmes import update. Import EQ and SSH separately. SvInjections #3333

Draft
wants to merge 106 commits into
base: main
Choose a base branch
from

Conversation

marqueslanauja
Copy link
Contributor

@marqueslanauja marqueslanauja commented Feb 24, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?

  • Yes, the corresponding issue is here
  • No

What is the current behavior?

EQ and SSH are imported together during the conversion process.

What is the new behavior (if this is a feature change)?
EQ and SSH are imported separately.
This PR contains only the changes for svInjections.

In the current version, depending on the configuration, fictitious loads are created associated with svInjections. However, in this PR, these loads cannot be created during the conversion process, as svInjections are part of the SV file. They are created just before the first update when the EQ and SV files are received together. If the EQ and SV files are received separately, they are never created.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>

# Conflicts:
#	cgmes/cgmes-completion/src/test/java/com/powsybl/cgmes/completion/CgmesCompletionTest.java
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Conversion.java
#	iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NetworkImpl.java
Signed-off-by: marquesja1 <marquesja@aia.es>

# Conflicts:
#	cgmes/cgmes-completion/src/test/java/com/powsybl/cgmes/completion/CgmesCompletionTest.java
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Conversion.java
#	iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NetworkImpl.java
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
marqueslanauja and others added 29 commits February 6, 2025 10:33
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>

# Conflicts:
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/RegulatingControlMappingForStaticVarCompensators.java
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>
Signed-off-by: marquesja1 <marquesja@aia.es>

# Conflicts:
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/CgmesBoundary.java
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Conversion.java
#	cgmes/cgmes-conversion/src/test/resources/functional-logs/microGridBaseCaseBE-invalid-voltage-bus.txt
#	cgmes/cgmes-conversion/src/test/resources/functional-logs/microGridBaseCaseBE-target-deadband.txt
#	cgmes/cgmes-conversion/src/test/resources/functional-logs/microGridBaseCaseBE.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants