Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cgmes import update. Import EQ and SSH separately. VoltageLevels #3329

Draft
wants to merge 102 commits into
base: main
Choose a base branch
from
Draft

Cgmes import update. Import EQ and SSH separately. VoltageLevels #3329

wants to merge 102 commits into from

Conversation

marqueslanauja
Copy link
Contributor

@marqueslanauja marqueslanauja commented Feb 20, 2025 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?

  • Yes, the corresponding issue is here
  • No

What is the current behavior?

EQ and SSH are imported together during the conversion process.

What is the new behavior (if this is a feature change)?

EQ and SSH are imported separately.
This PR contains only the changes for voltageLevels.

In IIDM, at each voltage level, only one value can be registered per limit: one for the lowVoltageLimit and another for the highVoltageLimit. If more than one value is received, then the most restrictive value is taken and for these values (lowVoltageLimit and highVoltageLimit) the operationalLimitSet, the operationalLimit and the normalValue are recorded as properties. These attributes will be used during the update process.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@marqueslanauja
update loads.
dcce636 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Update loads
6bc53a8 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Adjust validationUtil
0241870 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Adjust FunctionalLogsTests
e1e04b2 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix all the tests
3eafccf 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix issues
3884a51 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Pretty code
71bb0f0 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Pretty code
fafaf11 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Pretty code
004b824 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
update
8dc44cf 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Typo
81954c6 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Typo
2e6657b 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Updating report
cbb0f54 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into cgmes_import_update_network_loads
2812eec 
Signed-off-by: marquesja1 <marquesja@aia.es>

# Conflicts:
#	cgmes/cgmes-completion/src/test/java/com/powsybl/cgmes/completion/CgmesCompletionTest.java
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Conversion.java
#	iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NetworkImpl.java
@marqueslanauja
Merge branch 'main' into cgmes_import_update_network_transformers
32559be 
Signed-off-by: marquesja1 <marquesja@aia.es>

# Conflicts:
#	cgmes/cgmes-completion/src/test/java/com/powsybl/cgmes/completion/CgmesCompletionTest.java
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Conversion.java
#	iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NetworkImpl.java
@marqueslanauja
update voltage and angles after the update
b3d0945 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix code smells
7e3766a 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Minor changes
df10d15 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Pretty code
5114bde 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Reduce complexity
69ade84 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Reduce complexity
e4b95b3 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Undo mistake made before
81376bd 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
pretty code
e7da075 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Some improvements
4884abb 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Some improvements
779d778 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
More improvements
cdc18f7 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
update by using static classes
5b2796c 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Remove unused methods
324c805 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
update by using static classes
160edf1 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Update comment
c9075ca 
Signed-off-by: marquesja1 <marquesja@aia.es>
marqueslanauja and others added 29 commits January 30, 2025 15:45
@marqueslanauja
Remove duplicated code
9b90b21 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Clean regulating control
1f7fa62 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
update danglingLines
8191bbe 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into cgmes_import_update_network_danglingLines
99db5fd
@marqueslanauja
Fix bug
e208f7e 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
update lines
43a5563 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix issues
5d8b1f1 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
minor changes
7981f55 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Minor changes
0249a1f 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Improve svVoltages
6281fb2 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Add operationalLimits tests in danglingLines and transformers
be39fa4 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix issue
50c889e 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix issues
1ec858d 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
update switches
824dd0d 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into cgmes_import_update_network_switches
e965cd4 
Signed-off-by: marquesja1 <marquesja@aia.es>

# Conflicts:
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/RegulatingControlMappingForStaticVarCompensators.java
@marqueslanauja
Fix issue
9c57fe3 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Fix issue
91ba341 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
add SV unit tests
3a0b6ce 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into cgmes_import_update_network_switches
aa0aae5
@marqueslanauja
Minor changes
30aac85 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
voltage and angle update
8f21734 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into cgmes_import_update_network_switches
a4308be
@marqueslanauja
Minor change
f8fe98e 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
TieLine unit tests
09fbc87 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
remove unused variable
043f8fb 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
update voltageLevels
decda24 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
improve switches created from disconnected terminals
25cf477 
Signed-off-by: marquesja1 <marquesja@aia.es>
@marqueslanauja
Merge branch 'main' into cgmes_import_update_network_voltageLevels
33d418a 
Signed-off-by: marquesja1 <marquesja@aia.es>

# Conflicts:
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/CgmesBoundary.java
#	cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/Conversion.java
#	cgmes/cgmes-conversion/src/test/resources/functional-logs/microGridBaseCaseBE-invalid-voltage-bus.txt
#	cgmes/cgmes-conversion/src/test/resources/functional-logs/microGridBaseCaseBE-target-deadband.txt
#	cgmes/cgmes-conversion/src/test/resources/functional-logs/microGridBaseCaseBE.txt
@marqueslanauja
TieLines when there are more than two danglingLines at the boundary node
fba993e 
Signed-off-by: marquesja1 <marquesja@aia.es>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.4% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marqueslanauja @zamarrenolm