Fix missing buses in bus breaker view #3246
Merged
+40
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
geofjamg
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
@flo-dup thanks for this looooooooonnnnng time topology issue. Thanks to this we are now allowed to clean many bus/breaker buses (coming from node/breaker model) null buses which cannot exist anymore.
- One example (from myself...) of a bad workaround is the utility class https://github.com/powsybl/powsybl-core/blob/main/iidm/iidm-api/src/main/java/com/powsybl/iidm/network/Equipments.java which does not seem to be used in core itself but maybe in other repositories.
- Also we need to search for now unnecessary null checks.
- Maybe there are some places like in CGMES importer where we try to find some equivalent terminals (to check I'm not 100% sure) to also workaround this issue when importing a bus/breaker model.
olperr1
approved these changes
Feb 27, 2025
9 tasks
|
I marked this PR as draft as some cleaning could be done following this (the connectableBus getter becomes non-nullable in bus breaker view). That is now in a separate PR, hence we can merge this. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Connectables which are not connected to any switch / internal connection in node breaker do not have a calculated bus in bus breaker view, whereas connectables which are connected to a dangling internal connection do have a calculated bus.
What is the new behavior (if this is a feature change)?
All connectables of a node breaker voltage level do have a calculated bus in bus breaker view (in particular connectables which are not connected to any switch / internal connection)
Does this PR introduce a breaking change or deprecate an API?