Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of filter in controlarea query #3222

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

rcourtier
Copy link
Member

@rcourtier rcourtier commented Nov 21, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Improve performance

What is the current behavior?

ControlArea SPARQL query is using a FILTER REGEX clause. This isn't optimal performance-wise.

What is the new behavior (if this is a feature change)?

The query has been slightly changed to use a VALUES clause instead, which gives better performances.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

A similar work has been done in #3218 to remove the FILTER clause of NonlinearShuntCompensatorPoints qurery.

@rcourtier rcourtier self-assigned this Nov 21, 2024
@rcourtier rcourtier marked this pull request as draft November 21, 2024 15:28
@rcourtier rcourtier force-pushed the remove_use_of_filter_in_controlarea_query branch from c03bbfc to 49055e8 Compare February 10, 2025 11:54
@rcourtier rcourtier marked this pull request as ready for review February 10, 2025 13:54
@olperr1 olperr1 force-pushed the remove_use_of_filter_in_controlarea_query branch from 49055e8 to 60377c5 Compare February 25, 2025 09:11
Base automatically changed from remove_cgmes_control_areas_extension to main February 25, 2025 09:38
Signed-off-by: Romain Courtier <romain.courtier@rte-france.com>
Signed-off-by: Romain Courtier <romain.courtier@rte-france.com>
@olperr1 olperr1 force-pushed the remove_use_of_filter_in_controlarea_query branch from 60377c5 to 52a71c3 Compare February 25, 2025 10:22
@olperr1 olperr1 merged commit b5d9269 into main Feb 25, 2025
8 checks passed
@olperr1 olperr1 deleted the remove_use_of_filter_in_controlarea_query branch February 25, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants