Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scalable] If equipment is disconnected, then it is not scaled #2605

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

colinepiloquet
Copy link
Member

@colinepiloquet colinepiloquet commented Jun 7, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Between a bug fix and a feature

What is the current behavior?

Disconnected equipments can be reconnected after scaling but they are scaled in any case

What is the new behavior (if this is a feature change)?
If parameters is to not reconnect, then the equipment is not scaled

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
colinepiloquet and others added 3 commits June 7, 2023 17:11
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 8af2947 into main Jun 13, 2023
@annetill annetill deleted the scalable_if_disconnected_do_nothing branch June 13, 2023 09:27
olperr1 pushed a commit that referenced this pull request Jun 20, 2023
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants