-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove iidm converter api #2350
Conversation
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
# Conflicts: # cgmes/cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/export/EquipmentExportTest.java # cgmes/cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/export/StateVariablesExportTest.java # iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/IidmImportExportMode.java # iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/XMLExporter.java # iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/XMLImporter.java
# Conflicts: # cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/CgmesExport.java # cgmes/cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/export/EquipmentExportTest.java # cgmes/cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/export/StateVariablesExportTest.java # cgmes/cgmes-conversion/src/test/java/com/powsybl/cgmes/conversion/test/export/TopologyExportTest.java # iidm/iidm-converter-api/pom.xml # powerfactory/powerfactory-converter/pom.xml
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that a save
method implies that it is saved in a database or an object, which is okay when saved in a datasource but less obvious when we want to write a network in a file. It is just a remark though and I don't have a better name idea. Maybe discriminate with write
when passing a path or a file/directory name, save
otherwise?
I just wanted to be symmetrical with 'load' as load and save are often used together.
|
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
# Conflicts: # security-analysis/security-analysis-api/src/main/java/com/powsybl/security/tools/SecurityAnalysisTool.java
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
47f6f90
to
de7b9ca
Compare
SonarCloud Quality Gate failed. |
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Redesign of network loading and saving API
What is the current behavior? (You can also link to an open issue here)
We can import/export or load/save a network using utility classes Importers and Exporters.
What is the new behavior (if this is a feature change)?
We have removed the iidm-converter-api module and moved everything to iidm-api and all loading and saving functions have been moved to
Network
classDoes this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)