Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powerfactory: Generator converter, for targetP and targetQ use pgini_a and qgini_a if are available #2337

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

marqueslanauja
Copy link
Contributor

@marqueslanauja marqueslanauja commented Oct 23, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)

pgini and qgini is used for targetP and targetQ in generators.

What is the new behavior (if this is a feature change)?

pgini_a and qgini_a is used for targetP and targetQ in generators when they are available otherwise pgini and qgini is used.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

marqueslanauja and others added 3 commits October 23, 2022 19:49
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
@zamarrenolm zamarrenolm marked this pull request as ready for review October 24, 2022 07:00
@zamarrenolm zamarrenolm requested a review from miovd October 24, 2022 07:01
@miovd miovd requested a review from geofjamg October 24, 2022 08:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@annetill annetill merged commit 7992861 into main Oct 25, 2022
@annetill annetill deleted the powerfactory_pgini_a branch October 25, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants