Refactor actions JSON serialization / deserialization + plugin mechanism #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use jackson mechanisms for type resolution. One serializer/deserializer for each action type. Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
third party actions serialization. Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
miovd
approved these changes
Oct 17, 2022
geofjamg
approved these changes
Oct 17, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#2213
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature + refactoring.
What is the new behavior (if this is a feature change)?
SecurityAnalysisJsonPluginallows to provide jackson modules to increase JSON serialization with, in particular, new action types.@miovd @geofjamg : does this module-based plugin looks OK to you ?
In the existing code, there are only plugins for extensions serialization, for which we have provide SPI at the more granular serializer/deserializer level, so the approach is a little different here ...