PowerFactory: allow empty matrices in DGS parser #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luma <zamarrenolm@aia.es>
zamarrenolm
changed the title
geofjamg
approved these changes
Sep 12, 2022
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
marqueslanauja
approved these changes
Sep 12, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luma zamarrenolm@aia.es
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
DGS lines in a data block may have empty matrices (mTaps), even if the header declared a specific size.
The parser always expected at least the number of rows and cols declared in the header.
What is the new behavior (if this is a feature change)?
The DGS lines may have empty matrices (with either columns or rows equal to zero).
All matrices must have exactly the number of columns declared in the header .