-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hypotheses to create a voltage level on a line and to attach a line to another line #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56a0c29
to
6dcfbff
Compare
703dd69
to
6beb624
Compare
…ne to another line Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com> Add javadoc Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com> Typo Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com> Typo Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
6beb624
to
ae45e3c
Compare
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
annetill
approved these changes
Feb 14, 2022
geofjamg
reviewed
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only potential NPE in case of IDs not found in the network to fix.
...m-modification/src/main/java/com/powsybl/iidm/modification/topology/AttachNewLineOnLine.java
Show resolved
Hide resolved
...m-modification/src/main/java/com/powsybl/iidm/modification/topology/AttachNewLineOnLine.java
Show resolved
Hide resolved
...m-modification/src/main/java/com/powsybl/iidm/modification/topology/AttachNewLineOnLine.java
Show resolved
Hide resolved
...ification/src/main/java/com/powsybl/iidm/modification/topology/AttachVoltageLevelOnLine.java
Show resolved
Hide resolved
...ification/src/main/java/com/powsybl/iidm/modification/topology/AttachVoltageLevelOnLine.java
Show resolved
Hide resolved
...ification/src/main/java/com/powsybl/iidm/modification/topology/AttachVoltageLevelOnLine.java
Show resolved
Hide resolved
Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Kudos, SonarCloud Quality Gate passed! |
colinepiloquet
pushed a commit
that referenced
this pull request
Mar 8, 2022
…ne to another line (#1945) Signed-off-by: VEDELAGO MIORA <miora.ralambotiana@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: VEDELAGO MIORA miora.ralambotiana@rte-france.com
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'
and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Moving code from powsybl/powsybl-network-hypothesis and correcting code
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)