Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages to the gemspec #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amonaksis
Copy link

@amonaksis amonaksis commented Feb 14, 2025

It closes #6 .

How to test it:

rake build 
gem unpack pkg/<generated>.gem

Check the folder name inside the unpackaged folder you should see packages folder with all package definitions.

@yrashk
Copy link
Contributor

yrashk commented Feb 17, 2025

Thank you for the contribution!

I think I understand where this comes from – there's an underemphasized expectation that pgpm will look for the packages directory in the current work directory.

I don't think we should be putting extension definitions into the pgpm package because that'll mean we have to cut a new release every time anything's changed about this. This will conflate pgpm's own versioning with package versioning and require updated at all times.

The expected model is to supply the packages directory (it's also configurable in the pgpm tool) to the script. Do you have any ideas on how to make this whole workflow more natural and better understood?

@jonatas
Copy link
Contributor

jonatas commented Feb 18, 2025

I was testing this with @amonaksis last Friday and I suggested this fix.

My understanding was that the built image should contain or fetch the latest release, and have the ability to also sync it locally. The interesting part is that we ran the command in the pgpm directory, but the packages weren't added.

Is there any recommendation on how to bind the packages folder or why it was not working from the official image?

@yrashk
Copy link
Contributor

yrashk commented Feb 18, 2025

It looks in the current directory by default. Were you running it as ./exe/pgpm ...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing packages inside pgpm gem
3 participants