Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to react 16.3 #1428

Merged
merged 1 commit into from
Apr 24, 2018
Merged

upgrade to react 16.3 #1428

merged 1 commit into from
Apr 24, 2018

Conversation

meg2208
Copy link
Collaborator

@meg2208 meg2208 commented Apr 24, 2018

Closes #1427 and will be useful for a few other issues.

➜  popcode git:(react-16.3) ✗ yarn list react                      
yarn list v0.27.5
└─ react@16.3.2

@outoftime
Copy link
Contributor

@meg2208 should #1402 be included in this?

@meg2208
Copy link
Collaborator Author

meg2208 commented Apr 24, 2018

This version is definitely compatible with those lifecycle methods, so I would say no need, but #1402 should be considered a pretty high priority since we are going to want to upgrade to 16.4 if we start using StrictMode. According to this in this version it will only throw a deprecation warning when you turn on StrictMode or AsyncMode in 16.3. Looks like #1402 is definitely a strict requirement for 16.4, but that is not out yet.

@meg2208
Copy link
Collaborator Author

meg2208 commented Apr 24, 2018

@outoftime I would like to merge this asap so I can use AsyncMode for #1426 and we wouldn't have to add any dependencies for the async rendering.

Copy link
Contributor

@outoftime outoftime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meg2208 OK, yeah from looking at the changelog/article I share your conclusion that 16.3 itself does not introduce any new deprecations, so I’m down to merge this on the merits.

However, I’m not sure that this should immediately change the picture for #1426, for a couple reasons:

  • As far as I can tell, AsyncMode is still an unstable API in 16.3—generally I think we should prefer a stable third-party library to an unstable built-in, and then make the switch when the built-in becomes stable.
  • From a VERY cursory glance, I’m not sure that AsyncMode is what we want anyway—I think that concerns asynchronous prop updates as a performance optimization, rather than rendering a component contingent on the outcome of an asynchronous operation (i.e. a Promise). I could definitely be wrong about this though.

Anywho, I still see no reason not to go ahead and upgrade, so I’m gonna merge this!

@outoftime outoftime merged commit 5c63a76 into popcodeorg:master Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants