Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote proxy support to AH Kusama #535

Merged
merged 58 commits into from
Feb 28, 2025
Merged

Add remote proxy support to AH Kusama #535

merged 58 commits into from
Feb 28, 2025

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Jan 9, 2025

This adds remote proxy support to AssetHub on Polkadot and Kusama. Currently it is configured only to support using proxies registered on the relay chain to work on AssetHub. In the future this can be expanded.

Copy link
Contributor

@xlc xlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not in polkadot-sdk repo so how do we want to test it on westend?

@bkchr
Copy link
Contributor Author

bkchr commented Jan 10, 2025

this is not in polkadot-sdk repo so how do we want to test it on westend?

I will also port it there. I wanted to include it in the next release if possible. People are having more and more these problems of proxies not being on AH and similar. This pallet could solve the issue without requiring a root referendum (we already had one and another is prepared AFAIK).

@bkchr bkchr marked this pull request as ready for review January 15, 2025 20:49
@bkchr bkchr mentioned this pull request Jan 15, 2025
6 tasks
@bkchr bkchr changed the title Add remote proxy pallet Add remote proxy support to AH Polkadot&Kusama Jan 16, 2025
@acatangiu
Copy link
Contributor

I'd be more comfortable if we also did a security audit for this before adding it to live Polkadot AssetHub

@bkchr
Copy link
Contributor Author

bkchr commented Jan 17, 2025

I'd be more comfortable if we also did a security audit for this before adding it to live Polkadot AssetHub

The scope of the changes is quite narrow. Doing some proper review should be fine. The only difference to the real proxy pallet is that the data is coming in from the outside.

@bkchr bkchr changed the title Add remote proxy support to AH Polkadot&Kusama Add remote proxy support to AH Kusama Jan 27, 2025
@fellowship-merge-bot
Copy link
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@bkchr bkchr merged commit 6b85bf6 into main Feb 28, 2025
58 of 59 checks passed
@bkchr
Copy link
Contributor Author

bkchr commented Feb 28, 2025

Fuck why was this merged 🙈

@bkchr
Copy link
Contributor Author

bkchr commented Feb 28, 2025

Apparently some checks were not part of the required checks 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants