feat(template): enable insecure_zero_ed feature of pallet-balances #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable insecure_zero_ed feature of pallet-balances by default - enable rpc-binary-search-estimate feature by default - update integration tests
sorpaas
reviewed
Jan 5, 2024
| @@ -35,7 +35,7 @@ hex = { workspace = true } | |||
| libsecp256k1 = { workspace = true, features = ["static-context", "hmac"] } | |||
| rlp = { workspace = true } | |||
| # Substrate | |||
| pallet-balances = { workspace = true, features = ["default"] } | |||
| pallet-balances = { workspace = true, features = ["default", "insecure_zero_ed"] } | |||
There was a problem hiding this comment.
The problem with this is that it makes it not possible to disable the insecure_zero_ed feature any more.
There was a problem hiding this comment.
The pallet-balances dependency here is only used for tests.
I only enable the insecure_zero_ed feature in tests and template
sorpaas
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insecure_zero_edfeature ofpallet-balancesby default and setExistentialDeposit= 0rpc-binary-search-estimatefeature by defaultClose #1108