Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deliverability-stats): show all errors in descending order #942

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

ben-pr-p
Copy link
Contributor

Description

This PR fixes the sorting of message error codes and removes the .slice(0, 5), so all error codes are shown.

The previous use of .sort((a, b) => -1 | 0 | 1) was treating it like a .sortBy function, which had the effect of doing no sorting and leaving the elements in their server returned order.

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My commit messages follow the Conventional Commits specification.
  • My change requires a change to the documentation.
  • I have included updates for the documentation accordingly.

@ben-pr-p ben-pr-p requested a review from bchrobot April 15, 2021 01:36
@bchrobot bchrobot merged commit 9ba3320 into master Apr 15, 2021
@bchrobot bchrobot deleted the feat/show-all-errors branch April 15, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants