Configurable recursive description #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Dec 14, 2018
| @@ -33,6 +33,7 @@ If you'd like to submit your own custom strategy, see [Contributing](../CONTRIBU | |||
| - [`.image`](#image-7) | |||
| - [`.recursiveDescription`](#recursivedescription-2) | |||
| - [`UIViewController`](#uiviewcontroller) | |||
| - [`.hierarchy`](#hierarchy) | |||
There was a problem hiding this comment.
Adding your .hierarchy strategy to the documentation.
stephencelis
commented
Dec 14, 2018
| @@ -472,6 +472,40 @@ private final class NavigationDelegate: NSObject, WKNavigationDelegate { | |||
| #endif | |||
|
|
|||
| #if os(iOS) || os(tvOS) | |||
| func prepareView( | |||
There was a problem hiding this comment.
Now we can prepare views for text-based snapshots, as well.
stephencelis
commented
Dec 14, 2018
| @@ -0,0 +1,53 @@ | |||
| <UITableView; frame = (0 0; 320 568); clipsToBounds = YES; autoresize = W+H; gestureRecognizers = <NSArray>; layer = <CALayer>; contentOffset: {0, -20}; contentSize: {320, 440}; adjustedContentInset: {20, 0, 0, 0}> | |||
There was a problem hiding this comment.
This snapshot is now on a specific device override.
stephencelis
commented
Dec 14, 2018
| | <UINavigationController>, state: disappeared, view: <UILayoutContainerView> not in the window | ||
| | | <UIPageViewController>, state: disappeared, view: (view not loaded) | ||
| | | | <UIViewController>, state: disappeared, view: <UIView> not in the window | ||
| <UITabBarController>, state: appeared, view: <UILayoutContainerView> |
There was a problem hiding this comment.
Now that we add the view controller to a window it can show what's "appeared".
szotyi
pushed a commit
to szotyi/swift-snapshot-testing
that referenced
this pull request
Jan 3, 2019
* Configurable recursive description * Make private again * Fix comment * Remove stale snap * Change tests * Update Available-Snapshot-Strategies.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124.