Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++11move/rvalue ctor support for Dynamic::Var, Buffer and std::auto_ptr cleanup #778

Closed
wants to merge 18 commits into from
Closed

C++11move/rvalue ctor support for Dynamic::Var, Buffer and std::auto_ptr cleanup #778

wants to merge 18 commits into from

Conversation

mkrivos
Copy link
Member

@mkrivos mkrivos commented Apr 14, 2015

No description provided.

@trusch
Copy link

trusch commented Apr 14, 2015

+1

This makes my own pullrequest pointless (only the auto_ptr changes)!
Am 14.04.2015 07:47 schrieb "Marian Krivoš" notifications@github.com:

You can view, comment on, or merge this pull request online at:

#778
Commit Summary

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#778.

@trusch trusch mentioned this pull request Apr 14, 2015
Closed
@aleks-f
Copy link
Member

aleks-f commented Apr 14, 2015

Travis build is failing, can you check it?

Also, instead of peppering code with #if __cplusplus >= 201103L, can we have the POCO_ENABLE_CPP11 defined based on it:

#if __cplusplus >= 201103L
  #define POCO_ENABLE_CPP11 
#endif

@aleks-f
Copy link
Member

aleks-f commented Apr 14, 2015

And, if we decided to drop older compilers, then I guess we shouldn't be #idef-ing C++11 code. @obiltschnig ?

@mkrivos
Copy link
Member Author

mkrivos commented Apr 14, 2015

Yes, we must define some more policies:

  1. when exactly we enable POCO_ENABLE_CPP11 macro ? By configuration paremeter? By autodetection (cmake) ?
  2. Nor gcc 4.6 nor vs2013 are not fully CPP11 compatible. We can set VS2012 CPP11 features as the base (gcc 4.6 is rather VS superset from this view). Feature that is not covered by VS we can use conditionally with POCO_ENABLE_CPP11 macro ?

Any ideas?

@mkrivos
Copy link
Member Author

mkrivos commented Apr 14, 2015

@aleks-f
It seems that error is from missing c++11 support (not enabled by default).
Which way we use for c++11 enablement for standard makefile build? Cmake build is easy.

@aleks-f
Copy link
Member

aleks-f commented Apr 14, 2015

POCO_ENABLE_CPP11 can be enabled in Config.h automatically, based on __cplusplus__ macro version; I see you have added CMake check; we can also add the flag to configure script for posix builds. Given what we are trying to do, it should probably be renamed to POCO_ENABLE_FULL_CPP11

VS2012/gcc.4.8 should be a "point of no return" and C++11 features desired but not available there should be compiled conditionally. At this time, the only thing I am immediately interested in are variadic templates (for make_shared, not available in VS2012).

@mkrivos
Copy link
Member Author

mkrivos commented Apr 15, 2015

@aleks-f what next?

@aleks-f
Copy link
Member

aleks-f commented Apr 15, 2015

Waiting for @obiltschnig to look over this.

@aleks-f aleks-f mentioned this pull request May 21, 2015
Merged
@aleks-f aleks-f added this to the Release 1.7.0 milestone Jun 24, 2015
@RangelReale
Copy link
Contributor

I included this patch in my c++11 port, so I think this can be closed.

@aleks-f aleks-f closed this Jan 5, 2016
@mkrivos mkrivos deleted the c++11 branch February 15, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@obiltschnig obiltschnig

Labels
enhancement
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mkrivos @trusch @aleks-f @RangelReale @obiltschnig