Added missing IPv6 methods to SecureSocketImpl #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roccocorsi
reviewed
Aug 11, 2018
|
Any idea, when this is going life? |
|
Thanks for considering this for the next release. The commit 06d9846 works on my systems like expected. For completeness sake "SecureServerSocketImpl" and "SecureSocketImpl" are lacking the bind6 function with the reuse port flag. Not a big thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #2418
I noticed that bind6 was missing for SecureSocketImpl. Simply a matter of adding the method in a similar manner like bind. Solved it for me