Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling with clang_cl_x64_x64 on Visual Studio 2022 failed #3716

Closed
shakilodim opened this issue Jul 26, 2022 · 1 comment
Closed

Compiling with clang_cl_x64_x64 on Visual Studio 2022 failed #3716

shakilodim opened this issue Jul 26, 2022 · 1 comment

Comments

@shakilodim
Copy link

POCO master
Windows 10
Visual Studio 2022, 17.2.6, CMake, toolset clang_cl_x64_x64 failed with output:

[430/631] Building CXX object Net\CMakeFiles\Net.dir\src\PollSet.cpp.obj
FAILED: Net/CMakeFiles/Net.dir/src/PollSet.cpp.obj
C:\PROGRA1\MICROS4\2022\COMMUN~1\VC\Tools\Llvm\x64\bin\clang-cl.exe /nologo -TP -DNet_EXPORTS -DPOCO_ENABLE_CPP11 -DPOCO_ENABLE_CPP14 -DPOCO_NO_AUTOMATIC_LIBS -DPOCO_OS_FAMILY_WINDOWS -DUNICODE -D_DEBUG -D_UNICODE -IC:\Users\shaki\source\github\poco\Net\include -IC:\Users\shaki\source\github\poco\Net\src -IC:\Users\shaki\source\github\poco\Foundation\include -m64 -fdiagnostics-absolute-paths /DWIN32 /D_WINDOWS /W3 /GR /EHsc /Zc:__cplusplus /MDd /Zi /Ob0 /Od /RTC1 -std:c++14 /showIncludes /FoNet\CMakeFiles\Net.dir\src\PollSet.cpp.obj /FdNet\CMakeFiles\Net.dir\ -c -- C:\Users\shaki\source\github\poco\Net\src\PollSet.cpp
C:\Users\shaki\source\github\poco\Net\src\PollSet.cpp(76,26): error : ordered comparison between pointer and zero ('void *' and 'int')
if ((err) || (_epollfd < 0))
~~~~~~~~ ^ ~
C:\Users\shaki\source\github\poco\Net\src\PollSet.cpp(89,16): error : ordered comparison between pointer and zero ('void *' and 'int')
if (_epollfd >= 0) close(_epollfd);
~~~~~~~~ ^ ~
C:\Users\shaki\source\github\poco\Net\src\PollSet.cpp(144,17): error : ordered comparison between pointer and zero ('void *' and 'int')
if (_epollfd < 0) SocketImpl::error();
~~~~~~~~ ^ ~
3 errors generated.

@shakilodim shakilodim added the bug label Jul 26, 2022
@aleks-f
Copy link
Member

aleks-f commented Jul 27, 2022

well, try to static_cast it to int and send pull to devel branch if it works. MSVC compiler seems to have no problem with it

@aleks-f aleks-f added this to the Release 1.12.2 milestone Jul 27, 2022
aleks-f added a commit that referenced this issue Aug 7, 2022
* chore: 1.12.2 versions and notes

* chore: spelling fix

* fix(): Linking Crypto-testrunner fails #3688

* fix(Event): POSIX Event state need not be atomic #3699

* fix(OpenSSLInitializer): SIGABRT in OSSL_PROVIDER_unload with static OpenSSL3 #3698

* #3700: Release script must include build_vs170.cmd

* fix(mingw): lowercase winsock2 and iphlpapi to allow cross compile #3711

* fix(PollSet): wakeup fd is never read #3708

* fix(PollSet): wakeup fd is never read (windows portion and some other optimizations) #3708

* fix(PollSet): wakeup fd is never read #3708

* fix(PollSet): Compiling with clang_cl_x64_x64 on Visual Studio 2022 failed #3716

* fix(SpinlockMutex): VS2022 compilation issues #3693

* Only support extracting JSON fields when the SDK supports it (#3717)

* Added preprocessor defined to detect support for JSON

* Only support extracting JSON fields when the SDK supports it

* Fix version comparison

* fix(MSVC): PocoNet Project File does not support Visual Studio 2022 #3719

* Update max MSVC version information (#3720)

add visual studio 2022 support

* Added missing Crypto Header to ProGen source (#3722)

* fix(Crypto): fails to build with Visual Studio projects #3721

* Crypto: Progen again to add new files and bring back ARM64 configuration (#3724)

* Progen Crypto to re-add ARM64

* Add new files

* Add how to install using Conan section on README (#3727)

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* fix(Platform): LoongArch support #3460

* fix(format): Poco::format and C++20 #3733

* fix: g++ C++20 warnings #3734

* core(CI): add c++20

* fix(CI): skip MySQL tests for c++20

* release 1.12.2

Co-authored-by: Günter Obiltschnig <guenter.obiltschnig@appinf.com>
Co-authored-by: Hernan Martinez <hernan.c.martinez@gmail.com>
Co-authored-by: Byungjun Lee <40881444+OneTop4458@users.noreply.github.com>
Co-authored-by: Hernan Martinez <hmartinez@malwarebytes.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@aleks-f aleks-f closed this as completed Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants