Support python 3.11 and aiohttp 3.8 #224

marcinsulikowski · 2022-10-19T21:04:21Z

Remove remnants of aiohttp 2.x and Python 3.5 support

Commit adfb650 removed support for aiohttp 2.x and Python
3.5 but there are still some remnants of these left. We get rid of them.
This also removes one mypy warning:

compat.py:31: error: All conditional function variants must have identical signatures [misc]

Add type annotation for stream_reader_factory

Remove aiohttp 2.x from tox.ini

We no longer run tests against aiohttp 2.x so we don't need it in
tox.ini.

Add Python 3.10 support

aioresponses works with Python 3.10 with no issues so we update the
package metadata to say that, and we update the list of test
environments to include Python 3.10.

Add tests against aiohttp 3.8

aioresponses works with aiohttp 3.8 so we extend the list of test
environments to include this version.

Add Python 3.10 tests to GitHub workflows

Add tests against aiohttp 3.8 to GitHub workflows

Drop Python 3.6 support

We cannot run tests with Python 3.10 using Pytest 6.x due to [1]. This
is fixed in Pytest 7.x but Pytest 7.x no longer supports Python 3.6
which aioresponses tries to support. However because Python 3.6 is
already past the EOL date, the simplest solution is to no longer test
with Python 3.6 and to stop declaring support for that version.

[1] pytest-dev/pytest#8546

Update Pytest to the latest version to fix tests on Python 3.10

Our tests are filing on Python 3.10 due to [1] so we update Pytest in
requirements-dev.txt to the latest version.

[1] pytest-dev/pytest#8546

Don't test with aiohttp 3.6 and older on Python 3.10

aiohttp 3.6 and older use Python features which were removed in Python
3.10:

            assert port is not None
>           hosts = await asyncio.shield(self._resolve_host(
                host,
                port,
                traces=traces), loop=self._loop)
E               TypeError: shield() got an unexpected keyword argument 'loop'

.tox/py3.10-aiohttp35/lib/python3.10/site-packages/aiohttp/connector.py:952: TypeError

To avoid test failures, we remove unsupported combinations from GitHub
workflows.

Drop support for aiohttp 3.2.x and older

aiohttp 3.2.x and older don't work on Python 3.7 and because we now
require Python 3.7+, we can drop support for aiohttp 3.0, 3.1, and 3.2.

Merge remote-tracking branch 'pnuckowski/aioresponses/master' into support-python-3.10-and-aiohttp-3.8

Add Python 3.11 support

aioresponses works with Python 3.11 with no issues so we update the
package metadata to say that, and we update the list of test
environments to include Python 3.11. Python 3.11 is supported by aiohttp
starting from its v3.8 ([1]), and we also need newer yarl ([2]).

[1] aio-libs/aiohttp#6600
[2] aio-libs/yarl#706

Commit adfb650 removed support for aiohttp 2.x and Python 3.5 but there are still some remnants of these left. We get rid of them. This also removes one `mypy` warning: > compat.py:31: error: All conditional function variants must have identical signatures [misc]

We no longer run tests against aiohttp 2.x so we don't need it in `tox.ini`.

marcinsulikowski · 2022-10-19T21:05:10Z

A couple places in README files should also be updated but this is covered by #223

marcinsulikowski · 2022-10-19T21:34:39Z

I needed a few attempts but it seems that all test combinations are finally passing.

aioresponses works with Python 3.10 with no issues so we update the package metadata to say that, and we update the list of test environments to include Python 3.10.

aioresponses works with aiohttp 3.8 so we extend the list of test environments to include this version.

marcinsulikowski · 2022-10-19T22:21:23Z

But the coverage report tells that there's some dead code. Let me fix that as well.

We cannot run tests with Python 3.10 using Pytest 6.x due to [1]. This is fixed in Pytest 7.x but Pytest 7.x no longer supports Python 3.6 which aioresponses tries to support. However because Python 3.6 is already past the EOL date, the simplest solution is to no longer test with Python 3.6 and to stop declaring support for that version. [1] pytest-dev/pytest#8546

Our tests are filing on Python 3.10 due to [1] so we update Pytest in `requirements-dev.txt` to the latest version. [1] pytest-dev/pytest#8546

aiohttp 3.6 and older use Python features which were removed in Python 3.10: assert port is not None > hosts = await asyncio.shield(self._resolve_host( host, port, traces=traces), loop=self._loop) E TypeError: shield() got an unexpected keyword argument 'loop' .tox/py3.10-aiohttp35/lib/python3.10/site-packages/aiohttp/connector.py:952: TypeError To avoid test failures, we remove unsupported combinations from GitHub workflows.

aiohttp 3.2.x and older don't work on Python 3.7 and because we now require Python 3.7+, we can drop support for aiohttp 3.0, 3.1, and 3.2.

codecov-commenter · 2022-10-19T22:29:32Z

Codecov Report

Base: 96.50% // Head: 96.68% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (0f723fe) compared to base (f330e71).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   96.50%   96.68%   +0.18%     
==========================================
  Files           3        3              
  Lines         343      332      -11     
==========================================
- Hits          331      321      -10     
+ Misses         12       11       -1

Impacted Files	Coverage Δ
aioresponses/compat.py	`75.67% <100.00%> (+0.67%)`	⬆️
aioresponses/core.py	`99.31% <100.00%> (-0.02%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pnuckowski · 2022-12-14T00:16:16Z

Wow, a lot of work was done :)
Yes, lets drop py36

gaby · 2022-12-14T05:18:54Z

Looking forward to seeing this get merged! 🎉

marcinsulikowski · 2023-02-18T13:20:17Z

Things changed a but since I created this PR. I will add conflict resolution and support for 3.11.

…pport-python-3.10-and-aiohttp-3.8

aioresponses works with Python 3.11 with no issues so we update the package metadata to say that, and we update the list of test environments to include Python 3.11. Python 3.11 is supported by aiohttp starting from its v3.8 ([1]), and we also need newer `yarl` ([2]). [1] aio-libs/aiohttp#6600 [2] aio-libs/yarl#706

gaby · 2023-02-18T14:00:10Z

@pnuckowski This PR is ready now

avalanchy · 2023-03-29T08:41:09Z

@pnuckowski bump!

iamibi · 2023-04-25T02:00:17Z

aioresponses/compat.py

@@ -5,6 +5,7 @@
 from urllib.parse import parse_qsl, urlencode

 from aiohttp import __version__ as aiohttp_version, StreamReader
+from aiohttp.client_proto import ResponseHandler
 from multidict import MultiDict
 from pkg_resources import parse_version


The package throws the following warning when running locally

DeprecationWarning: pkg_resources is deprecated as an API

The official documentation suggests the use of importlib.resources, importlib.metadata as a replacement. More info here: https://setuptools.pypa.io/en/stable/pkg_resources.html

All that's being used here is parse_version with literal version strings. I'd suggest packaging.version.parse instead of anything from importlib.

@pnuckowski Is anything else blocking this from being merged and released? I got bit by this today and the PR has been sitting for a long time now.

Failing that, does anyone know of a fork that includes Python 3.11 support?

@brettdh I'm wondering the same thing :-S

I can confirm that all unit tests pass in Python 3.11.4 after changing this line (and one other like it, in tests/test_aioresponses.py) to this:

from packaging.version import parse as parse_version

Using a private fork for now, but hoping that can get fixed, merged, and released soon.

gaby · 2023-06-19T21:32:25Z

@pnuckowski Thank you! 💪

brettdh · 2023-06-20T02:39:36Z

I was very confused about:

why this was merged without the pkg_resources fix above; and
why tests are passing on 3.11 even without that fix; and
why import aioresponses still failed in my project's 3.11 virtualenv; AND
why import pkg_resources failed in my project's 3.11 virtualenv but succeeded in my aioresponses 3.11 virtualenv

and then I realised that my aioresponses virtualenv also includes setuptools, and my other project's virtualenv does not (for some reason, perhaps owing to me having created the former with python -m venv and the other with pyenv virtualenv create). 😑 Mystery (mostly) solved.

@pnuckowski Thanks for the quick response and for merging! Looking forward to a new release.

brettdh · 2023-06-20T02:55:53Z

Er, whoops; celebrated too soon. The pkg_resources issue above means that aioresponses still fails with this error in my project's unit tests (under pytest):

ImportError while importing test module '/Users/brhiggins/src/myproj/tests/test_foo.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../../.pyenv/versions/3.11.4/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_foo.py:6: in <module>
    from aioresponses import aioresponses
../../../../.pyenv/versions/3.11.4/envs/myproj/lib/python3.11/site-packages/aioresponses/__init__.py:2: in <module>
    from .core import CallbackResult, aioresponses
../../../../.pyenv/versions/3.11.4/envs/myproj/lib/python3.11/site-packages/aioresponses/core.py:33: in <module>
    from .compat import (
../../../../.pyenv/versions/3.11.4/envs/myproj/lib/python3.11/site-packages/aioresponses/compat.py:10: in <module>
    from pkg_resources import parse_version
E   ModuleNotFoundError: No module named 'pkg_resources'

This is with aioresponses installed from 56b843319d5d0ae8a405f188e68d7ba8c7573bc8.

iamibi · 2023-06-20T02:58:24Z

Er, whoops; celebrated too soon. The pkg_resources issue above means that aioresponses still fails with this error in my project's unit tests (under pytest):

ImportError while importing test module '/Users/brhiggins/src/myproj/tests/test_foo.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../../.pyenv/versions/3.11.4/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_foo.py:6: in <module>
    from aioresponses import aioresponses
../../../../.pyenv/versions/3.11.4/envs/myproj/lib/python3.11/site-packages/aioresponses/__init__.py:2: in <module>
    from .core import CallbackResult, aioresponses
../../../../.pyenv/versions/3.11.4/envs/myproj/lib/python3.11/site-packages/aioresponses/core.py:33: in <module>
    from .compat import (
../../../../.pyenv/versions/3.11.4/envs/myproj/lib/python3.11/site-packages/aioresponses/compat.py:10: in <module>
    from pkg_resources import parse_version
E   ModuleNotFoundError: No module named 'pkg_resources'

This is with aioresponses installed from 56b843319d5d0ae8a405f188e68d7ba8c7573bc8.

The workaround is to install the setuptools when running test cases. Specially in case of CI builds. Any latest version of setuptools should work.

brettdh · 2023-06-20T03:11:58Z

@iamibi Thanks; that works for now.

marcinsulikowski added 3 commits October 19, 2022 22:44

Add type annotation for stream_reader_factory

cb2cd8f

Remove aiohttp 2.x from tox.ini

f3b31b5

We no longer run tests against aiohttp 2.x so we don't need it in `tox.ini`.

marcinsulikowski force-pushed the support-python-3.10-and-aiohttp-3.8 branch 2 times, most recently from 2ce038c to afd9bf9 Compare October 19, 2022 21:32

marcinsulikowski added 4 commits October 20, 2022 00:11

Add Python 3.10 support

ac868fb

aioresponses works with Python 3.10 with no issues so we update the package metadata to say that, and we update the list of test environments to include Python 3.10.

Add tests against aiohttp 3.8

5c326c1

aioresponses works with aiohttp 3.8 so we extend the list of test environments to include this version.

Add Python 3.10 tests to GitHub workflows

4d0eeb0

Add tests against aiohttp 3.8 to GitHub workflows

f2277bd

marcinsulikowski force-pushed the support-python-3.10-and-aiohttp-3.8 branch from afd9bf9 to 1c7d946 Compare October 19, 2022 22:21

marcinsulikowski mentioned this pull request Oct 19, 2022

Remove remnants of aiohttp 2.x and Python 3.5 support #223

Closed

marcinsulikowski added 4 commits October 20, 2022 00:28

Update Pytest to the latest version to fix tests on Python 3.10

79efa91

Our tests are filing on Python 3.10 due to [1] so we update Pytest in `requirements-dev.txt` to the latest version. [1] pytest-dev/pytest#8546

Drop support for aiohttp 3.2.x and older

d946dcb

aiohttp 3.2.x and older don't work on Python 3.7 and because we now require Python 3.7+, we can drop support for aiohttp 3.0, 3.1, and 3.2.

marcinsulikowski force-pushed the support-python-3.10-and-aiohttp-3.8 branch from 1c7d946 to d946dcb Compare October 19, 2022 22:29

hf-kklein mentioned this pull request Oct 20, 2022

Specify type of stream_reader_factory #208

Open

marcinsulikowski added 2 commits February 18, 2023 14:21

Merge remote-tracking branch 'pnuckowski/aioresponses/master' into su…

b401e6c

…pport-python-3.10-and-aiohttp-3.8

marcinsulikowski changed the title ~~Support python 3.10 and aiohttp 3.8~~ Support python 3.11 and aiohttp 3.8 Feb 18, 2023

iamibi reviewed Apr 25, 2023

View reviewed changes

pnuckowski approved these changes Jun 19, 2023

View reviewed changes

pnuckowski merged commit 56b8433 into pnuckowski:master Jun 19, 2023

GeeCastro mentioned this pull request Sep 19, 2023

Can we get a 0.7.5 release? #245

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support python 3.11 and aiohttp 3.8 #224

Support python 3.11 and aiohttp 3.8 #224

marcinsulikowski commented Oct 19, 2022 •

edited

Loading

marcinsulikowski commented Oct 19, 2022

marcinsulikowski commented Oct 19, 2022

marcinsulikowski commented Oct 19, 2022

codecov-commenter commented Oct 19, 2022 •

edited

Loading

pnuckowski commented Dec 14, 2022 •

edited

Loading

gaby commented Dec 14, 2022

marcinsulikowski commented Feb 18, 2023

gaby commented Feb 18, 2023

avalanchy commented Mar 29, 2023

iamibi Apr 25, 2023

brettdh Jun 19, 2023

gaby Jun 19, 2023

brettdh Jun 19, 2023

gaby commented Jun 19, 2023

brettdh commented Jun 20, 2023

brettdh commented Jun 20, 2023

iamibi commented Jun 20, 2023

brettdh commented Jun 20, 2023

Support python 3.11 and aiohttp 3.8 #224

Support python 3.11 and aiohttp 3.8 #224

Conversation

marcinsulikowski commented Oct 19, 2022 • edited Loading

Remove remnants of aiohttp 2.x and Python 3.5 support

Add type annotation for stream_reader_factory

Remove aiohttp 2.x from tox.ini

Add Python 3.10 support

Add tests against aiohttp 3.8

Add Python 3.10 tests to GitHub workflows

Add tests against aiohttp 3.8 to GitHub workflows

Drop Python 3.6 support

Update Pytest to the latest version to fix tests on Python 3.10

Don't test with aiohttp 3.6 and older on Python 3.10

Drop support for aiohttp 3.2.x and older

Merge remote-tracking branch 'pnuckowski/aioresponses/master' into support-python-3.10-and-aiohttp-3.8

Add Python 3.11 support

marcinsulikowski commented Oct 19, 2022

marcinsulikowski commented Oct 19, 2022

marcinsulikowski commented Oct 19, 2022

codecov-commenter commented Oct 19, 2022 • edited Loading

Codecov Report

pnuckowski commented Dec 14, 2022 • edited Loading

gaby commented Dec 14, 2022

marcinsulikowski commented Feb 18, 2023

gaby commented Feb 18, 2023

avalanchy commented Mar 29, 2023

iamibi Apr 25, 2023

Choose a reason for hiding this comment

brettdh Jun 19, 2023

Choose a reason for hiding this comment

gaby Jun 19, 2023

Choose a reason for hiding this comment

brettdh Jun 19, 2023

Choose a reason for hiding this comment

gaby commented Jun 19, 2023

brettdh commented Jun 20, 2023

brettdh commented Jun 20, 2023

iamibi commented Jun 20, 2023

brettdh commented Jun 20, 2023

marcinsulikowski commented Oct 19, 2022 •

edited

Loading

codecov-commenter commented Oct 19, 2022 •

edited

Loading

pnuckowski commented Dec 14, 2022 •

edited

Loading