Skip to content
This repository was archived by the owner on Jun 24, 2023. It is now read-only.

The editor root namespace has collisions #37

Open
krispya opened this issue Jan 6, 2023 · 0 comments
Open

The editor root namespace has collisions #37

krispya opened this issue Jan 6, 2023 · 0 comments

Comments

@krispya
Copy link
Member

krispya commented Jan 6, 2023

There are multiple namespace collisions with root.

  • The editor has a concept of root and at the same time, R3F also does. We keep track of both inside the editor currently and the names collide.
  • Inside of ThreeEditorCanvas, FiberCanvas uses #root for its id causing invalid HTML since there is already a div with #root. I know this is being used with useId so seems like there needs to be a more robust solution than just removing it or change the name.
@krispya krispya changed the title FiberCanvas uses #root for its id causing invalid HTML The editor root namespace has collisions Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant