cxl/json: Fix tracefs include. #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
../cxl/json.c:12:10: fatal error: tracefs/tracefs.h: No such file or directory pkg-config --cflags libtracefs -I/usr/include/libtracefs -I/usr/include/traceevent find /usr/include/ -name tracefs.h /usr/include/libtracefs/tracefs.h Signed-off-by: Michal Suchanek <msuchanek@suse.de>
hswong3i
added a commit
to alvistack/pmem-ndctl
that referenced
this pull request
Oct 11, 2024
git clean -xdf
tar zcvf ../ndctl_80.orig.tar.gz --exclude=.git .
debuild -uc -us
cp ndctl.spec ../ndctl_80-1.spec
cp ndctl.rpmlintrc /osc/home\:alvistack/pmem-ndctl-80/
cp ../ndctl*80*.{gz,xz,spec,dsc} /osc/home\:alvistack/pmem-ndctl-80/
rm -rf ../*ndctl*80*.* ../*daxctl*80*.* ../*libcxl*80*.*
See pmem#267
See pmem#268
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
added a commit
to alvistack/pmem-ndctl
that referenced
this pull request
Oct 11, 2024
git clean -xdf
tar zcvf ../ndctl_80.orig.tar.gz --exclude=.git .
debuild -uc -us
cp ndctl.spec ../ndctl_80-1.spec
cp ndctl.rpmlintrc /osc/home\:alvistack/pmem-ndctl-80/
cp ../ndctl*80*.{gz,xz,spec,dsc} /osc/home\:alvistack/pmem-ndctl-80/
rm -rf ../*ndctl*80*.* ../*daxctl*80*.* ../*libcxl*80*.*
See pmem#267
See pmem#268
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
|
This fixes the build error on Alpine Linux. It is basically the same issue as here: #234 (v76.1) |
|
I tried to compile ndctl 80 release with |
AlisonSchofield
pushed a commit
that referenced
this pull request
Mar 3, 2025
Distros vary on whether tracefs.h is placed in {prefix}/libtracefs/
or {prefix}/tracefs/. Since the library ships with pkgconfig info
to determine the exact include path the #include statement can drop
the tracefs/ prefix.
This was previously found and fixed elsewhere:
a598663 ("cxl/monitor: fix include paths for tracefs and traceevent")
but was introduced anew with cxl media-error support in ndctl v80.
Reposted here from github pull request:
#268
[ alison: commit msg and log edits ]
Fixes: 9873123 ("cxl/list: collect and parse media_error records")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Marc Herbert <marc.herbert@intel.com>
Link: https://lore.kernel.org/r/20250209180348.1773179-1-alison.schofield@intel.com
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
AlisonSchofield
pushed a commit
that referenced
this pull request
Mar 3, 2025
Distros vary on whether tracefs.h is placed in {prefix}/libtracefs/
or {prefix}/tracefs/. Since the library ships with pkgconfig info
to determine the exact include path the #include statement can drop
the tracefs/ prefix.
This was previously found and fixed elsewhere:
a598663 ("cxl/monitor: fix include paths for tracefs and traceevent")
but was introduced anew with cxl media-error support in ndctl v80.
Reposted here from github pull request:
#268
[ alison: commit msg and log edits ]
Fixes: 9873123 ("cxl/list: collect and parse media_error records")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Marc Herbert <marc.herbert@intel.com>
Link: https://lore.kernel.org/r/20250209180348.1773179-1-alison.schofield@intel.com
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
../cxl/json.c:12:10: fatal error: tracefs/tracefs.h: No such file or directory
pkg-config --cflags libtracefs
-I/usr/include/libtracefs -I/usr/include/traceevent
find /usr/include/ -name tracefs.h
/usr/include/libtracefs/tracefs.h