Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError: When using orjson and serializing pandas.NA #5040

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Fix TypeError: When using orjson and serializing pandas.NA #5040

merged 2 commits into from
Feb 18, 2025

Conversation

DavidKatz-il
Copy link
Contributor

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or modified existing tests.
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

closes #5039

@gvwilson gvwilson requested a review from marthacryan February 18, 2025 14:43
@gvwilson gvwilson added P1 needed for current cycle community community contribution fix fixes something broken labels Feb 18, 2025
@gvwilson
Copy link
Contributor

Thanks for this @DavidKatz-il - I'll try to have someone review ASAP.

marthacryan
marthacryan approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@marthacryan marthacryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marthacryan marthacryan merged commit a6ee27c into plotly:main Feb 18, 2025
4 checks passed
@DavidKatz-il DavidKatz-il deleted the fix-5039 branch February 18, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marthacryan marthacryan marthacryan approved these changes

Assignees

@marthacryan marthacryan

Labels
community community contribution fix fixes something broken P1 needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: When using orjson and serializing pandas.NA
3 participants
@DavidKatz-il @gvwilson @marthacryan