Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heatmap/image traces without zsmooth on Safari/iOS #6605

Merged
merged 5 commits into from
May 15, 2023
Merged

Fix heatmap/image traces without zsmooth on Safari/iOS #6605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5840137
Fix heatmap/image traces without zsmooth on Safari
lvlte May 14, 2023
9467b44
Add draft log
lvlte May 14, 2023
1bb2b82
Fix heatmap/image traces without zsmooth on IOS
lvlte May 15, 2023
80503a5
Fix heatmap/image traces without zsmooth on IOS
lvlte May 15, 2023
67e611d
fix zsmooth false rendering : check useragent, improve readabiity
lvlte May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/6605_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix heatmap rendering on Safari when `zsmooth` is set to false [[#6605](https://github.com/plotly/plotly.js/pull/6605)], with thanks to @lvlte for the contribution!
28 changes: 20 additions & 8 deletions src/lib/supports_pixelated_image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,39 @@ function supportsPixelatedImage() {
if(_supportsPixelated !== null) { // only run the feature detection once
return _supportsPixelated;
}
if(Lib.isIE()) {
_supportsPixelated = false;
} else {

_supportsPixelated = false;

// @see https://github.com/plotly/plotly.js/issues/6604
var unsupportedBrowser = Lib.isIE() || Lib.isSafari() || Lib.isIOS();

if(window.navigator.userAgent && !unsupportedBrowser) {
var declarations = Array.from(constants.CSS_DECLARATIONS).reverse();
var supports = window.CSS && window.CSS.supports || window.supportsCSS;

var supports = (window.CSS && window.CSS.supports) || window.supportsCSS;
if(typeof supports === 'function') {
_supportsPixelated = declarations.some(function(d) {
return supports.apply(null, d);
});
} else {
var image3 = Drawing.tester.append('image');
var image3 = Drawing.tester.append('image')
.attr('style', constants.STYLE);

var cStyles = window.getComputedStyle(image3.node());
image3.attr('style', constants.STYLE);
var imageRendering = cStyles.imageRendering;

_supportsPixelated = declarations.some(function(d) {
var value = d[1];
return cStyles.imageRendering === value ||
cStyles.imageRendering === value.toLowerCase();
return (
imageRendering === value ||
imageRendering === value.toLowerCase()
);
});

image3.remove();
}
}

return _supportsPixelated;
}

Expand Down