Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid attaching internal d3 object to the window #6487

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Feb 15, 2023

Fixes #6483.
Regression introduced in v2.17.0 bundles.
@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Feb 15, 2023
@@ -70,7 +70,7 @@
]
},
"dependencies": {
"@plotly/d3": "3.8.0",
"@plotly/d3": "3.8.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 💃

@archmoj archmoj merged commit 506ed1c into master Feb 15, 2023
@archmoj archmoj deleted the avoid-d3-export branch February 15, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since 2.17.0, window.d3 is exported with internal 3.8.0 version preventing loading of external d3 library
2 participants