Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overlap of point and axis hover labels #6442

Merged
merged 16 commits into from
Mar 6, 2023
Merged

Avoid overlap of point and axis hover labels #6442

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d965131
Avoid overlap of point and axis hover labels
Jan 18, 2023
88d2475
Merge branch 'plotly:master' into master
dagroe Feb 24, 2023
c86a12b
Fix for overlap on other axis and other sides
Jan 24, 2023
126e432
Apply changes only for compare modes (hovermode: 'x'|'y')
Jan 24, 2023
782bc99
Apply changes only when hover labels intersect axis hover label
Jan 30, 2023
ded38a3
Ignore hover labels' arrows when calculating axis label overlap
Jan 31, 2023
08ff50b
Fix tests
Jan 31, 2023
0426f42
Fix bounds used: check overlap on y axis when hovermode is y
Feb 1, 2023
4c3438f
Add @noCI to test failing only on CI
Feb 6, 2023
3b83880
Ignore very small overlap
Feb 6, 2023
8805949
remove noCI from failing test
Feb 6, 2023
16adaac
use more descriptive variable names
Feb 7, 2023
c4383bc
Use rect behind text instead of text2 for collision check
Feb 24, 2023
9e75c94
Fix eslint in tests
Feb 24, 2023
e5cee9e
Use actual axis label background path instead of bounding box for col…
Feb 24, 2023
fe529fa
Add changelog
Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/fx/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1518,7 +1518,7 @@ function hoverAvoidOverlaps(hoverLabels, axKey, fullLayout) {
posref: d.posref,
size: d.by * (axIsX ? YFACTOR : 1) / 2,
pmin: 0,
pmax: (axIsX ? fullLayout.width : fullLayout.height)
pmax: (axIsX ? fullLayout.width : fullLayout.height) - ax._mainLinePosition
}];
});

Expand Down