Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change valType of rotation in pie to be angle #6304

Merged
merged 2 commits into from
Sep 20, 2022
Merged

change valType of rotation in pie to be angle #6304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edecef1
use valType of angle for pie rotation
archmoj Aug 30, 2022
67d5cc0
draft log for PR 6304
archmoj Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/6304_change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Use valType of `angle` for `rotation` in `pie` [[#6304](https://github.com/plotly/plotly.js/pull/6304)]
4 changes: 1 addition & 3 deletions src/traces/pie/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,7 @@ module.exports = {
].join(' ')
},
rotation: {
valType: 'number',
min: -360,
max: 360,
valType: 'angle',
dflt: 0,
editType: 'calc',
description: [
Expand Down
4 changes: 1 addition & 3 deletions test/plot-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41129,9 +41129,7 @@
"description": "Instead of the first slice starting at 12 o'clock, rotate to some other angle.",
"dflt": 0,
"editType": "calc",
"max": 360,
"min": -360,
"valType": "number"
"valType": "angle"
},
"scalegroup": {
"description": "If there are multiple pie charts that should be sized according to their totals, link them by providing a non-empty group id here shared by every trace in the same group.",
Expand Down