Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for 2022 logo #6232

Merged
merged 12 commits into from
Jul 6, 2022
Merged

Updates for 2022 logo #6232

merged 12 commits into from
Jul 6, 2022

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jun 15, 2022

demo
@plotly/plotly_js

cc: @angeladaodao

Please note that we use #777 (with a white border line) instead of plain black and white bars i.e. to handle various background colors in plotly.js graphs.
Also gradient in the original logo is replaced by simple colors for points.

@alexcjohnson
Copy link
Collaborator

This looks OK, but it wouldn't be that hard to have the bars adapt to the background color: on a dark background make them white, on a light background make them black. Just give them a class but no fill or stroke, and set it explicitly (to color.contrast(paper_bgcolor) - which actually picks #444 instead of black) both after drawing the modebar and after setting a background color.

@angeladaodao
Copy link

How about something like this?

logo_icon_svg-01

@archmoj
Copy link
Contributor Author

archmoj commented Jun 16, 2022

This looks OK, but it wouldn't be that hard to have the bars adapt to the background color: on a dark background make them white, on a light background make them black. Just give them a class but no fill or stroke, and set it explicitly (to color.contrast(paper_bgcolor) - which actually picks #444 instead of black) both after drawing the modebar and after setting a background color.

Good call and I could definitely try that.
However one may argue that the logo should be visible on various colors of the graph not necessarily in respect to the background. Namely because users could locate the modebar at a different position.

@alexcjohnson
Copy link
Collaborator

True. But if it’s not over the background color it’s likely to be over a mix of multiple colors… in which case short of filling around the logo with a solid color (@angeladaodao is that what you were suggesting?) there’s really nothing we can do to make it robustly visible.

@angeladaodao
Copy link

That is correct

@archmoj archmoj requested a review from alexcjohnson July 6, 2022 00:37
Co-authored-by: Alex Johnson <alex@plot.ly>
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 (BTW when looking at the changelog to verify the correct form I notice a few recent ones missing the # - perhaps something to fix while prepping for the next release)

@archmoj archmoj merged commit 95b3bd1 into master Jul 6, 2022
@archmoj archmoj deleted the update-logo-2022 branch July 6, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants