-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for 2022 logo #6232
Updates for 2022 logo #6232
Conversation
This looks OK, but it wouldn't be that hard to have the bars adapt to the background color: on a dark background make them white, on a light background make them black. Just give them a class but no fill or stroke, and set it explicitly (to |
Good call and I could definitely try that. |
True. But if it’s not over the background color it’s likely to be over a mix of multiple colors… in which case short of filling around the logo with a solid color (@angeladaodao is that what you were suggesting?) there’s really nothing we can do to make it robustly visible. |
That is correct |
Co-authored-by: Alex Johnson <alex@plot.ly>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 (BTW when looking at the changelog to verify the correct form I notice a few recent ones missing the #
- perhaps something to fix while prepping for the next release)
demo
@plotly/plotly_js
cc: @angeladaodao
Please note that we use
#777
(with a white border line) instead of plain black and white bars i.e. to handle various background colors in plotly.js graphs.Also gradient in the original logo is replaced by simple colors for points.