Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node.js v14 in tests and publishing #5919

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Use node.js v14 in tests and publishing #5919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c024d64
try using node.js v14 instead of v12
archmoj Sep 1, 2021
6f87587
require node 14 in preversion
archmoj Sep 1, 2021
9a64710
log for PR 5919
archmoj Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ version: 2.0
jobs:
install-and-cibuild:
docker:
- image: circleci/node:12.22.5
- image: circleci/node:14.17.5
working_directory: ~/plotly.js
steps:
- checkout
Expand All @@ -34,7 +34,7 @@ jobs:
timezone-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:12.22.5-browsers
- image: circleci/node:14.17.5-browsers
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
no-gl-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:12.22.5-browsers
- image: circleci/node:14.17.5-browsers
environment:
# Alaska time (arbitrary timezone to test date logic)
TZ: "America/Anchorage"
Expand All @@ -79,7 +79,7 @@ jobs:
webgl-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:12.22.5-browsers
- image: circleci/node:14.17.5-browsers
environment:
# Alaska time (arbitrary timezone to test date logic)
TZ: "America/Anchorage"
Expand All @@ -95,7 +95,7 @@ jobs:
flaky-no-gl-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:12.22.5-browsers
- image: circleci/node:14.17.5-browsers
environment:
# Alaska time (arbitrary timezone to test date logic)
TZ: "America/Anchorage"
Expand All @@ -110,7 +110,7 @@ jobs:
bundle-jasmine:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:12.22.5-browsers
- image: circleci/node:14.17.5-browsers
environment:
# Alaska time (arbitrary timezone to test date logic)
TZ: "America/Anchorage"
Expand Down Expand Up @@ -143,7 +143,7 @@ jobs:

test-baselines:
docker:
- image: circleci/node:12.22.5
- image: circleci/node:14.17.5
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:

test-exports:
docker:
- image: circleci/node:12.22.5
- image: circleci/node:14.17.5
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand All @@ -192,7 +192,7 @@ jobs:

mock-validation:
docker:
- image: circleci/node:12.22.5
- image: circleci/node:14.17.5
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand All @@ -206,7 +206,7 @@ jobs:

source-syntax:
docker:
- image: circleci/node:12.22.5
- image: circleci/node:14.17.5
working_directory: ~/plotly.js
steps:
- attach_workspace:
Expand All @@ -217,7 +217,7 @@ jobs:

publish-dist:
docker:
- image: circleci/node:12.22.5
- image: circleci/node:14.17.5
working_directory: ~/plotly.js
steps:
- checkout
Expand Down
1 change: 1 addition & 0 deletions draftlogs/5919_change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Use node.js v14 in tests and publishing [[#5919](https://github.com/plotly/plotly.js/pull/5919)]
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"start": "node devtools/test_dashboard/server.js",
"baseline": "node test/image/make_baseline.js",
"noci-baseline": "npm run cibuild && ./tasks/noci_test.sh image && git checkout dist && echo 'Please do not commit unless the change was expected!'",
"preversion": "check-node-version --node 12 --npm 6.14 && npm-link-check && npm ls --prod",
"preversion": "check-node-version --node 14 --npm 6.14 && npm-link-check && npm ls --prod",
"version": "npm run build && npm run no-bad-char && git add -A lib dist build src/version.js",
"postversion": "node -e \"console.log('Version bumped and committed. If ok, run: git push && git push --tags')\"",
"postpublish": "node tasks/sync_packages.js",
Expand Down