Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump color modules to fix import problem using webpack #5189

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 2, 2020

Fixes #5182 thanks to #5182 (comment).
@dy do you still suggest additional changes e.g. #5182 (comment) in the plotly.js package file?

@plotly/plotly_js

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can revisit the issue of what our main entry point should be later, but for the time being let's keep it and just bump the color modules. Nice detective work @dy @archmoj ! 💃

@archmoj archmoj merged commit 6583929 into master Oct 2, 2020
@archmoj archmoj deleted the bump-color-modules branch October 2, 2020 13:01
@dy
Copy link
Contributor

dy commented Oct 2, 2020

As for repointing "main" entry - now that makes plotly consumer DX inconvenient - webpack eats away around 1s (admittedly) of bundling time, if not more. (user rebundles the same amount as when you generate new plotly bundle). Switching it to dist will save all that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken regression this used to work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color dependencies cause initial import to break
3 participants