-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve labels on axes with rangebreaks #5187
Conversation
I'm still seeing some funny behavior. If I take your codepen https://codepen.io/MojtabaSamimi/pen/jOqjzga and comment out I'm not worried about the random tick dropping, that's a compromise we need to make when there are range breaks and can't always tell if the labels will overlap. But it's important that we position the labels correctly in all of these situations. All of these situations I got to just by slowly dragging the right side of the x axis. I didn't investigate zooming in, only zooming out, so there may be other funny cases when you zoom in. Please make sure that the labels are positioned correctly with automatic ticks and tick labels at all zoom levels. |
…klabelmode features together
13eb10f
to
ab6b57a
Compare
…ould reduce ticks - revert changes of date_axes baseline - update date_axes2 baseline - fixup jasmine tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Whew, nice job, that took persistence!
Fixes #5129 and fixes #5176.
Set
dtick
in respect totickformat
forperiod
labels and fixup label positioning on axes withrangebreaks
demo1: Before vs After
demo2: Before vs After
demo3: Before vs After
demo4: Before vs After
@plotly/plotly_js